Minor cleanup

UPGRADE.md

@@ -34,7 +34,7 @@ Report your issue on Xibalba BBS, hop in #enigma-bbs on FreeNode and chat, or
 * All features and changes are backwards compatible. There are a few new configuration options in a new `term` section in the configuration. These are all optional, but include the following options in case you use them:
 
 ```hjson
-{ 
+{
 
   term: {
     // checkUtf8Encoding requires the use of cursor position reports, which are not supported on all terminals.
@@ -54,6 +54,7 @@ Report your issue on Xibalba BBS, hop in #enigma-bbs on FreeNode and chat, or
 ```
 
 In addition to these, there are also new options for `term.cp437TermList` and `term.utf8TermList`. Under most circumstances these should not need to be changed. If you want to customize these lists, more information is available in `config_default.js`
+* To enable the new Waiting for Caller (WFC) support, please see [WFC](docs/modding/wfc.md).
 
 # 0.0.11-beta to 0.0.12-beta
 * Be aware that `master` is now mainline! This means all `git pull`'s will yield the latest version. See [WHATSNEW](WHATSNEW.md) for more information.

WHATSNEW.md

@@ -5,8 +5,8 @@ This document attempts to track **major** changes and additions in ENiGMA½. For
 * **Note for contributors**: ENiGMA has switched to [Prettier](https://prettier.io) for formatting/style. Please see [CONTRIBUTING](CONTRIBUTING.md) and the Prettier website for more information.
 * Removed terminal `cursor position reports` from most locations in the code. This should greatly increase the number of terminal programs that work with Enigma 1/2. For more information, see [Issue #222](https://github.com/NuSkooler/enigma-bbs/issues/222). This may also resolve other issues, such as [Issue #365](https://github.com/NuSkooler/enigma-bbs/issues/365), and [Issue #320](https://github.com/NuSkooler/enigma-bbs/issues/320). Anyone that previously had terminal incompatibilities please re-check and let us know!
 * Bumped up the minimum [Node.js](https://nodejs.org/en/) version to v14. This will allow more expressive Javascript programming syntax with ECMAScript 2020 to improve the development experience.
+* **New Waiting For Caller (WFC)** support via the `wfc.js` module.
 * Added new configuration options for `term.checkUtf8Encoding`, `term.checkAnsiHomePostion`, `term.cp437TermList`, and `term.utf8TermList`. More information on these options is available in [UPGRADE](UPGRADE.md).
-* New Waiting For Caller (WFC) support via the `wfc.js` module.
 * Many new system statistics available via the StatLog such as current and average load, memory, etc.
 * Many new MCI codes: `MB`, `MF`, `LA`, `CL`, `UU`, `FT`, `DD`, `FB`, `DB`, `LC`, `LT`, `LD`, and more. See [MCI](./docs/art/mci.md).
 * SyncTERM style font support detection.

core/bbs.js

@@ -2,9 +2,6 @@
 /* eslint-disable no-console */
 'use strict';
 
-//var SegfaultHandler = require('segfault-handler');
-//SegfaultHandler.registerHandler('enigma-bbs-segfault.log');
-
 //  ENiGMA½
 const conf = require('./config.js');
 const logger = require('./logger.js');

core/bbs_link.js

@@ -129,7 +129,7 @@ exports.getModule = class BBSLinkModule extends MenuModule {
                         '/auth.php?key=' + randomKey,
                         headers,
                         function resp(err, body) {
-                            var status = body.trim();
+                            const status = body.trim();
 
                             if ('complete' === status) {
                                 return callback(null);

core/client_term.js

@@ -2,19 +2,19 @@
 'use strict';
 
 //  ENiGMA½
-var Log = require('./logger.js').log;
+const Log = require('./logger.js').log;
-var renegadeToAnsi = require('./color_codes.js').renegadeToAnsi;
+const renegadeToAnsi = require('./color_codes.js').renegadeToAnsi;
 const Config = require('./config.js').get;
-var iconv = require('iconv-lite');
+const iconv = require('iconv-lite');
-var assert = require('assert');
+const assert = require('assert');
-var _ = require('lodash');
+const _ = require('lodash');
 
 exports.ClientTerminal = ClientTerminal;
 
 function ClientTerminal(output) {
     this.output = output;
 
-    var outputEncoding = 'cp437';
+    let outputEncoding = 'cp437';
     assert(iconv.encodingExists(outputEncoding));
 
     //  convert line feeds such as \n -> \r\n
@@ -26,10 +26,10 @@ function ClientTerminal(output) {
     //  Some terminal we handle specially
     //  They can also be found in this.env{}
     //
-    var termType = 'unknown';
+    let termType = 'unknown';
-    var termHeight = 0;
+    let termHeight = 0;
-    var termWidth = 0;
+    let termWidth = 0;
-    var termClient = 'unknown';
+    let termClient = 'unknown';
 
     this.currentSyncFont = 'not_set';
 

core/config_loader.js

@@ -69,7 +69,7 @@ module.exports = class ConfigLoader {
                             defaultConfig,
                             config,
                             (defaultVal, configVal, key, target, source) => {
-                                var path;
+                                let path;
                                 while (true) {
                                     //  eslint-disable-line no-constant-condition
                                     if (!stack.length) {

docs/_docs/modding/wfc.md

@@ -16,7 +16,7 @@ The system allows any user with the proper security to access the WFC / system o
 3. User ID of 1 (root/admin)
 4. The user belongs to the `wfc` group.
 
-:information_source: Due to the above, the WFC screen is **disabled** by default as at a minimum, you'll need to add your user to the `wfc` group.
+> :information_source: Due to the above, the WFC screen is **disabled** by default as at a minimum, you'll need to add your user to the `wfc` group.
 
 To change the ACS required, specify a alternative `acs` in the `config` block. For example:
 ```hjson
@@ -28,7 +28,7 @@ mainMenuWaitingForCaller: {
 }
 ```
 
-:information_source: ENiGMA½ will enforce ACS of at least `SC` (secure connection)
+> :notebook: ENiGMA½ will enforce ACS of at least `SC` (secure connection)
 
 ## Theming
 The following MCI codes are available:
@@ -98,4 +98,4 @@ The following MCI codes are available:
     * `visIndicator`: Is the current user visible? Displayed via `statusVisibleIndicators` or system theme. See also [Themes](../art/themes.md).
 
 
-:information_source: While [Standard MCI](../art/mci.md) codes work on any menu, they will **not** refresh. For values that may change over time, please use the custom format values above.
+> :information_source: While [Standard MCI](../art/mci.md) codes work on any menu, they will **not** refresh. For values that may change over time, please use the custom format values above.