Code review changes

This commit is contained in:
Nathan Byrd 2022-07-31 12:53:34 -05:00
parent a2e6088238
commit c799f1f73c
2 changed files with 4 additions and 7 deletions

View File

@ -42,6 +42,10 @@ function ClientTerminal(output) {
}, },
set: function (enc) { set: function (enc) {
if (iconv.encodingExists(enc)) { if (iconv.encodingExists(enc)) {
Log.info(
{ encoding: enc, currentEncoding: outputEncoding },
'Setting client encoding.'
);
outputEncoding = enc; outputEncoding = enc;
} else { } else {
Log.warn({ encoding: enc }, 'Unknown encoding'); Log.warn({ encoding: enc }, 'Unknown encoding');

View File

@ -247,13 +247,6 @@ function setClientEncoding(callingMenu, formData, extraArgs, cb) {
const client = callingMenu.client; const client = callingMenu.client;
let encoding = formData.value.encoding; let encoding = formData.value.encoding;
client.log.info(
{ encoding: encoding, currentEncoding: client.term.outputEncoding },
'Setting client encoding.'
);
encoding = encoding || client.term.outputEncoding;
client.term.outputEncoding = encoding; client.term.outputEncoding = encoding;
return callingMenu.nextMenu(cb); return callingMenu.nextMenu(cb);