Additional fixes from code review comments
This commit is contained in:
parent
049c3a870a
commit
d4098ed114
|
@ -21,8 +21,7 @@ function ButtonView(options) {
|
|||
util.inherits(ButtonView, TextView);
|
||||
|
||||
ButtonView.prototype.onKeyPress = function(ch, key) {
|
||||
let actionForKeyName = key ? key.name : ch;
|
||||
if(this.isKeyMapped('accept', actionForKeyName) || ' ' === ch) {
|
||||
if(this.isKeyMapped('accept', (key ? key.name : ch)) || ' ' === ch) {
|
||||
this.submitData = 'accept';
|
||||
this.emit('action', 'accept');
|
||||
delete this.submitData;
|
||||
|
|
|
@ -792,7 +792,7 @@ exports.FullScreenEditorModule = exports.getModule = class FullScreenEditorModul
|
|||
},
|
||||
function prepareViewStates(callback) {
|
||||
let from = self.viewControllers.header.getView(MciViewIds.header.from);
|
||||
if (from !== undefined) {
|
||||
if (from) {
|
||||
from.acceptsFocus = false;
|
||||
}
|
||||
|
||||
|
@ -918,7 +918,7 @@ exports.FullScreenEditorModule = exports.getModule = class FullScreenEditorModul
|
|||
|
||||
initHeaderViewMode() {
|
||||
// Only set header text for from view if it is on the form
|
||||
if (self.viewControllers.header.getView(MciViewIds.header.from) !== undefined) {
|
||||
if (this.viewControllers.header.getView(MciViewIds.header.from) !== undefined) {
|
||||
this.setHeaderText(MciViewIds.header.from, this.message.fromUserName);
|
||||
}
|
||||
this.setHeaderText(MciViewIds.header.to, this.message.toUserName);
|
||||
|
|
Loading…
Reference in New Issue