moon
/
enigma-bbs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix event emitter leak

This commit is contained in:
Bryan Ashby 2018-07-15 22:08:09 -06:00
parent 013a947e15
commit e3c197c3e1
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
core/client.js
View File

@ -111,12 +111,13 @@ function Client(/*input, output*/) {
this.input.on('data', this.dataHandler); this.input.on('data', this.dataHandler);
}; };
Events.on(Events.getSystemEvents().ThemeChanged, ( { themeId } ) => { this.themeChangedListener = function( { themeId } ) {
if(_.get(this.currentTheme, 'info.themeId') === themeId) { if(_.get(self.currentTheme, 'info.themeId') === themeId) {
this.currentTheme = require('./theme.js').getAvailableThemes().get(themeId); self.currentTheme = require('./theme.js').getAvailableThemes().get(themeId);
} }
}); };
Events.on(Events.getSystemEvents().ThemeChanged, this.themeChangedListener);
// //
// Peek at incoming |data| and emit events for any special // Peek at incoming |data| and emit events for any special
@ -458,7 +459,9 @@ Client.prototype.end = function () {
this.term.disconnect(); this.term.disconnect();
} }
var currentModule = this.menuStack.getCurrentModule; Events.removeListener(Events.getSystemEvents().ThemeChanged, this.themeChangedListener);
const currentModule = this.menuStack.getCurrentModule;
if(currentModule) { if(currentModule) {
currentModule.leave(); currentModule.leave();
@ -470,10 +473,9 @@ Client.prototype.end = function () {
// //
// We can end up calling 'end' before TTY/etc. is established, e.g. with SSH // We can end up calling 'end' before TTY/etc. is established, e.g. with SSH
// //
// :TODO: is this OK?
return this.output.end.apply(this.output, arguments); return this.output.end.apply(this.output, arguments);
} catch(e) { } catch(e) {
// TypeError // ie TypeError
} }
}; };