Merge remote-tracking branch 'upstream/develop' into media-proxy

lib/pleroma/application.ex

@@ -20,6 +20,7 @@ def start(_type, _args) do
                          limit: 2500
                        ]]),
       worker(Pleroma.Web.Federator, []),
+      worker(Pleroma.Web.ChatChannel.ChatChannelState, []),
     ]
     ++ if Mix.env == :test, do: [], else: [worker(Pleroma.Web.Streamer, [])]
 

lib/pleroma/plugs/authentication_plug.ex

@@ -44,7 +44,7 @@ defp verify(user, password, _user_id) do
   defp decode_header(conn) do
     with ["Basic " <> header] <- get_req_header(conn, "authorization"),
          {:ok, userinfo} <- Base.decode64(header),
-         [username, password] <- String.split(userinfo, ":")
+         [username, password] <- String.split(userinfo, ":", parts: 2)
     do
       {:ok, username, password}
     end

lib/pleroma/user.ex

@@ -329,4 +329,9 @@ def blocks?(user, %{ap_id: ap_id}) do
     Enum.member?(blocks, ap_id)
   end
 
+  def local_user_query() do
+    from u in User,
+      where: u.local == true
+  end
+
 end

lib/pleroma/web/channels/user_socket.ex

@@ -1,8 +1,11 @@
 defmodule Pleroma.Web.UserSocket do
   use Phoenix.Socket
+  alias Pleroma.User
+  alias Comeonin.Pbkdf2
 
   ## Channels
   # channel "room:*", Pleroma.Web.RoomChannel
+  channel "chat:*", Pleroma.Web.ChatChannel
 
   ## Transports
   transport :websocket, Phoenix.Transports.WebSocket
@@ -19,8 +22,13 @@ defmodule Pleroma.Web.UserSocket do
   #
   # See `Phoenix.Token` documentation for examples in
   # performing token verification on connect.
-  def connect(_params, socket) do
-    {:ok, socket}
+  def connect(%{"token" => token}, socket) do
+    with {:ok, user_id} <- Phoenix.Token.verify(socket, "user socket", token, max_age: 84600),
+         %User{} = user <- Pleroma.Repo.get(User, user_id) do
+      {:ok, assign(socket, :user_name, user.nickname)}
+    else
+      _e -> :error
+    end
   end
 
   # Socket id's are topics that allow you to identify all sockets for a given user:

lib/pleroma/web/chat_channel.ex

@@ -0,0 +1,46 @@
+defmodule Pleroma.Web.ChatChannel do
+  use Phoenix.Channel
+  alias Pleroma.Web.ChatChannel.ChatChannelState
+  alias Pleroma.User
+
+  def join("chat:public", _message, socket) do
+    send(self(), :after_join)
+    {:ok, socket}
+  end
+
+  def handle_info(:after_join, socket) do
+    push socket, "messages", %{messages: ChatChannelState.messages()}
+    {:noreply, socket}
+  end
+
+  def handle_in("new_msg", %{"text" => text}, %{assigns: %{user_name: user_name}} = socket) do
+    author = User.get_cached_by_nickname(user_name)
+    author = Pleroma.Web.MastodonAPI.AccountView.render("account.json", user: author)
+    message = ChatChannelState.add_message(%{text: text, author: author})
+
+    broadcast! socket, "new_msg", message
+    {:noreply, socket}
+  end
+end
+
+defmodule Pleroma.Web.ChatChannel.ChatChannelState do
+  use Agent
+  @max_messages 20
+
+  def start_link do
+    Agent.start_link(fn -> %{max_id: 1, messages: []} end, name: __MODULE__)
+  end
+
+  def add_message(message) do
+    Agent.get_and_update(__MODULE__, fn state ->
+      id = state[:max_id] + 1
+      message = Map.put(message, "id", id)
+      messages = [message | state[:messages]] |> Enum.take(@max_messages)
+      {message, %{max_id: id, messages: messages}}
+    end)
+  end
+
+  def messages() do
+    Agent.get(__MODULE__, fn state -> state[:messages] |> Enum.reverse end)
+  end
+end

lib/pleroma/web/mastodon_api/mastodon_api_controller.ex

@@ -93,6 +93,7 @@ def user(conn, %{"id" => id}) do
   @instance Application.get_env(:pleroma, :instance)
 
   def masto_instance(conn, _params) do
+    user_count = Repo.aggregate(User.local_user_query, :count, :id)
     response = %{
       uri: Web.base_url,
       title: Keyword.get(@instance, :name),
@@ -103,8 +104,8 @@ def masto_instance(conn, _params) do
         streaming_api: String.replace(Web.base_url, ["http","https"], "wss")
       },
       stats: %{
-        user_count: 1,
         status_count: 2,
+        user_count: user_count,
         domain_count: 3
       },
       max_toot_chars: Keyword.get(@instance, :limit)

lib/pleroma/web/ostatus/user_representer.ex

@@ -19,6 +19,7 @@ def to_simple_form(user) do
       {:"poco:preferredUsername", [nickname]},
       {:"poco:displayName", [name]},
       {:"poco:note", [bio]},
+      {:summary, [bio]},
       {:name, [nickname]},
       {:link, [rel: 'avatar', href: avatar_url], []}
     ] ++ banner

lib/pleroma/web/twitter_api/twitter_api_controller.ex

@@ -10,7 +10,8 @@ defmodule Pleroma.Web.TwitterAPI.Controller do
   require Logger
 
   def verify_credentials(%{assigns: %{user: user}} = conn, _params) do
-    render(conn, UserView, "show.json", %{user: user})
+    token = Phoenix.Token.sign(conn, "user socket", user.id)
+    render(conn, UserView, "show.json", %{user: user, token: token})
   end
 
   def status_update(%{assigns: %{user: user}} = conn, %{"status" => _} = status_data) do

lib/pleroma/web/twitter_api/views/user_view.ex

@@ -26,7 +26,7 @@ def render("user.json", %{user: user = %User{}} = assigns) do
 
     user_info = User.get_cached_user_info(user)
 
-    %{
+    data = %{
       "created_at" => user.inserted_at |> Utils.format_naive_asctime,
       "description" => HtmlSanitizeEx.strip_tags(user.bio),
       "favourites_count" => 0,
@@ -48,6 +48,12 @@ def render("user.json", %{user: user = %User{}} = assigns) do
       "cover_photo" => image_url(user.info["banner"]) |> MediaProxy.url(),
       "background_image" => image_url(user.info["background"]) |> MediaProxy.url(),
     }
+
+    if assigns[:token] do
+      Map.put(data, "token", assigns[:token])
+    else
+      data
+    end
   end
 
   def render("short.json", %{user: %User{

priv/repo/migrations/20171130135819_add_local_index_to_user.exs

@@ -0,0 +1,7 @@
+defmodule Pleroma.Repo.Migrations.AddLocalIndexToUser do
+  use Ecto.Migration
+
+  def change do
+    create index(:users, [:local])
+  end
+end

priv/static/index.html

@@ -1 +1 @@
-<!DOCTYPE html><html lang=en><head><meta charset=utf-8><meta name=viewport content="width=device-width,initial-scale=1"><title>Pleroma</title><link rel=stylesheet href=/static/font/css/fontello.css><link rel=stylesheet href=/static/font/css/animation.css><link href=/static/css/app.1c9a07d790a4262baf47d33a2a3e71c5.css rel=stylesheet></head><body style="display: none"><div id=app></div><script type=text/javascript src=/static/js/manifest.8e9b51ea14e08fc9a22a.js></script><script type=text/javascript src=/static/js/vendor.6ffc1793217fe26edf39.js></script><script type=text/javascript src=/static/js/app.a4d345815ef9d13e9524.js></script></body></html>
+<!DOCTYPE html><html lang=en><head><meta charset=utf-8><meta name=viewport content="width=device-width,initial-scale=1"><title>Pleroma</title><link rel=stylesheet href=/static/font/css/fontello.css><link rel=stylesheet href=/static/font/css/animation.css><link href=/static/css/app.67f64792f89a96e59442c437c7ded0b3.css rel=stylesheet></head><body style="display: none"><div id=app></div><script type=text/javascript src=/static/js/manifest.ee87253244897e08bdce.js></script><script type=text/javascript src=/static/js/vendor.50cd70f77f559bfe1f27.js></script><script type=text/javascript src=/static/js/app.fefccf252cac9e1310ea.js></script></body></html>

test/web/mastodon_api/mastodon_api_controller_test.exs

@@ -573,4 +573,19 @@ test "updates the user's banner" do
       assert user["header"] != "https://placehold.it/700x335"
     end
   end
+
+  test "get instance information" do
+    insert(:user, %{local: true})
+    user = insert(:user, %{local: true})
+    insert(:user, %{local: false})
+
+    {:ok, _} = TwitterAPI.create_status(user, %{"status" => "cofe"})
+
+    conn = conn
+    |> get("/api/v1/instance")
+
+    assert result = json_response(conn, 200)
+
+    assert result["stats"]["user_count"] == 2
+  end
 end

test/web/ostatus/user_representer_test.exs

@@ -18,6 +18,7 @@ test "returns a user with id, uri, name and link" do
     <poco:preferredUsername>#{user.nickname}</poco:preferredUsername>
     <poco:displayName>#{user.name}</poco:displayName>
     <poco:note>#{user.bio}</poco:note>
+    <summary>#{user.bio}</summary>
     <name>#{user.nickname}</name>
     <link rel="avatar" href="#{User.avatar_url(user)}" />
     """

test/web/twitter_api/twitter_api_controller_test.exs

@@ -22,7 +22,8 @@ test "with credentials", %{conn: conn, user: user} do
         |> with_credentials(user.nickname, "test")
         |> post("/api/account/verify_credentials.json")
 
-      assert json_response(conn, 200) == UserView.render("show.json", %{user: user})
+      assert response = json_response(conn, 200)
+      assert response == UserView.render("show.json", %{user: user, token: response["token"]})
     end
   end