EmojiReactValidator: use new qualification method

lib/pleroma/web/activity_pub/object_validators/emoji_react_validator.ex

@@ -63,8 +63,7 @@ defp fix(data) do
   end
 
   defp fix_emoji_qualification(%{"content" => emoji} = data) do
-    # Emoji variation sequence
+    new_emoji = Pleroma.Emoji.fully_qualify_emoji(emoji)
-    new_emoji = emoji <> "\uFE0F"
 
     cond do
       Pleroma.Emoji.is_unicode_emoji?(emoji) ->

test/fixtures/emoji-reaction-unqualified.json

@@ -1,30 +0,0 @@
-{
-  "type": "EmojiReact",
-  "signature": {
-    "type": "RsaSignature2017",
-    "signatureValue": "fdxMfQSMwbC6wP6sh6neS/vM5879K67yQkHTbiT5Npr5wAac0y6+o3Ij+41tN3rL6wfuGTosSBTHOtta6R4GCOOhCaCSLMZKypnp1VltCzLDoyrZELnYQIC8gpUXVmIycZbREk22qWUe/w7DAFaKK4UscBlHDzeDVcA0K3Se5Sluqi9/Zh+ldAnEzj/rSEPDjrtvf5wGNf3fHxbKSRKFt90JvKK6hS+vxKUhlRFDf6/SMETw+EhwJSNW4d10yMUakqUWsFv4Acq5LW7l+HpYMvlYY1FZhNde1+uonnCyuQDyvzkff8zwtEJmAXC4RivO/VVLa17SmqheJZfI8oluVg==",
-    "creator": "http://mastodon.example.org/users/admin#main-key",
-    "created": "2018-02-17T18:57:49Z"
-  },
-  "object": "http://localtesting.pleroma.lol/objects/eb92579d-3417-42a8-8652-2492c2d4f454",
-  "content": "❤",
-  "nickname": "lain",
-  "id": "http://mastodon.example.org/users/admin#reactions/2",
-  "actor": "http://mastodon.example.org/users/admin",
-  "@context": [
-    "https://www.w3.org/ns/activitystreams",
-    "https://w3id.org/security/v1",
-    {
-      "toot": "http://joinmastodon.org/ns#",
-      "sensitive": "as:sensitive",
-      "ostatus": "http://ostatus.org#",
-      "movedTo": "as:movedTo",
-      "manuallyApprovesFollowers": "as:manuallyApprovesFollowers",
-      "inReplyToAtomUri": "ostatus:inReplyToAtomUri",
-      "conversation": "ostatus:conversation",
-      "atomUri": "ostatus:atomUri",
-      "Hashtag": "as:Hashtag",
-      "Emoji": "toot:Emoji"
-    }
-  ]
-}

test/pleroma/web/activity_pub/transmogrifier/emoji_react_handling_test.exs

@@ -42,11 +42,15 @@ test "it works for incoming unqualified emoji reactions" do
     other_user = insert(:user, local: false)
     {:ok, activity} = CommonAPI.post(user, %{status: "hello"})
 
+    # woman detective emoji, unqualified
+    unqualified_emoji = [0x1F575, 0x200D, 0x2640] |> List.to_string()
+
     data =
-      File.read!("test/fixtures/emoji-reaction-unqualified.json")
+      File.read!("test/fixtures/emoji-reaction.json")
       |> Jason.decode!()
       |> Map.put("object", activity.data["object"])
       |> Map.put("actor", other_user.ap_id)
+      |> Map.put("content", unqualified_emoji)
 
     {:ok, %Activity{data: data, local: false}} = Transmogrifier.handle_incoming(data)
 
@@ -54,13 +58,14 @@ test "it works for incoming unqualified emoji reactions" do
     assert data["type"] == "EmojiReact"
     assert data["id"] == "http://mastodon.example.org/users/admin#reactions/2"
     assert data["object"] == activity.data["object"]
-    # heart emoji with added emoji variation sequence
+    # woman detective emoji, fully qualified
-    assert data["content"] == "❤\uFE0F"
+    emoji = [0x1F575, 0xFE0F, 0x200D, 0x2640, 0xFE0F] |> List.to_string()
+    assert data["content"] == emoji
 
     object = Object.get_by_ap_id(data["object"])
 
     assert object.data["reaction_count"] == 1
-    assert match?([["❤\uFE0F", _]], object.data["reactions"])
+    assert match?([[emoji, _]], object.data["reactions"])
   end
 
   test "it reject invalid emoji reactions" do