From 62491f6749748bb5c603e3d8772324438e623906 Mon Sep 17 00:00:00 2001
From: danidfra <danielfilemondev@gmail.com>
Date: Tue, 22 Oct 2024 20:26:07 -0300
Subject: [PATCH] Refactored nest ternary expressions

---
 .eslintrc.json                                |  2 +-
 src/actions/settings.ts                       |  3 +-
 src/features/admin/domains.tsx                |  4 +-
 .../components/registration-form.tsx          | 16 ++--
 src/features/backups/index.tsx                |  4 +-
 src/features/filters/index.tsx                | 82 ++++++++++---------
 .../modals/captcha-modal/captcha-modal.tsx    |  7 +-
 src/normalizers/admin-account.ts              |  8 +-
 8 files changed, 74 insertions(+), 52 deletions(-)

diff --git a/.eslintrc.json b/.eslintrc.json
index 84f6bb0b5..54e72c64f 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -133,7 +133,7 @@
     "no-irregular-whitespace": "error",
     "no-loop-func": "error",
     "no-mixed-spaces-and-tabs": "error",
-    "no-nested-ternary": "warn",
+    "no-nested-ternary": "error",
     "no-restricted-imports": [
       "error",
       {
diff --git a/src/actions/settings.ts b/src/actions/settings.ts
index 257656b74..e05771fdc 100644
--- a/src/actions/settings.ts
+++ b/src/actions/settings.ts
@@ -241,7 +241,8 @@ const saveSettings = (opts?: SettingOpts) =>
 const getLocale = (state: RootState, fallback = 'en') => {
   const localeWithVariant = (getSettings(state).get('locale') as string).replace('_', '-');
   const locale = localeWithVariant.split('-')[0];
-  return Object.keys(messages).includes(localeWithVariant) ? localeWithVariant : Object.keys(messages).includes(locale) ? locale : fallback;
+  const fallbackLocale = Object.keys(messages).includes(locale) ? locale : fallback;
+  return Object.keys(messages).includes(localeWithVariant) ? localeWithVariant : fallbackLocale;
 };
 
 type SettingsAction =
diff --git a/src/features/admin/domains.tsx b/src/features/admin/domains.tsx
index e2455f3f8..60a89d43f 100644
--- a/src/features/admin/domains.tsx
+++ b/src/features/admin/domains.tsx
@@ -51,7 +51,9 @@ const Domain: React.FC<IDomain> = ({ domain }) => {
     }));
   };
 
-  const domainState = domain.last_checked_at ? (domain.resolves ? 'active' : 'error') : 'pending';
+  const resolveState = domain.resolves ? 'active' : 'error';
+  const domainState = domain.last_checked_at ? resolveState : 'pending';
+
   const domainStateLabel = {
     active: <FormattedMessage id='admin.domains.resolve.success_label' defaultMessage='Resolves correctly' />,
     error: <FormattedMessage id='admin.domains.resolve.fail_label' defaultMessage='Not resolving' />,
diff --git a/src/features/auth-login/components/registration-form.tsx b/src/features/auth-login/components/registration-form.tsx
index 19259ff52..ea5c9c94b 100644
--- a/src/features/auth-login/components/registration-form.tsx
+++ b/src/features/auth-login/components/registration-form.tsx
@@ -141,13 +141,19 @@ const RegistrationForm: React.FC<IRegistrationForm> = ({ inviteToken }) => {
         /></p>}
     </>);
 
+    const confirmationHeading = needsConfirmation
+      ? intl.formatMessage(messages.needsConfirmationHeader)
+      : undefined;
+
+    const approvalHeading = needsApproval
+      ? intl.formatMessage(messages.needsApprovalHeader)
+      : undefined;
+
+    const heading = confirmationHeading || approvalHeading;
+
     dispatch(openModal('CONFIRM', {
       icon: require('@tabler/icons/outline/check.svg'),
-      heading: needsConfirmation
-        ? intl.formatMessage(messages.needsConfirmationHeader)
-        : needsApproval
-          ? intl.formatMessage(messages.needsApprovalHeader)
-          : undefined,
+      heading: heading,
       message,
       confirm: intl.formatMessage(messages.close),
     }));
diff --git a/src/features/backups/index.tsx b/src/features/backups/index.tsx
index 9cac7cb13..6c9d97f92 100644
--- a/src/features/backups/index.tsx
+++ b/src/features/backups/index.tsx
@@ -88,12 +88,14 @@ const Backups = () => {
     </Card>
   );
 
-  const body = showLoading ? <Spinner /> : backups.isEmpty() ? emptyMessage : (
+  const backupsContent = backups.isEmpty() ? emptyMessage : (
     <div className='mb-4 grid grid-cols-1 gap-4 sm:grid-cols-2'>
       {backups.map((backup) => <Backup key={backup.id} backup={backup} />)}
     </div>
   );
 
+  const body = showLoading ? <Spinner /> : backupsContent;
+
   return (
     <Column label={intl.formatMessage(messages.heading)}>
       {body}
diff --git a/src/features/filters/index.tsx b/src/features/filters/index.tsx
index 41001c396..99e46039b 100644
--- a/src/features/filters/index.tsx
+++ b/src/features/filters/index.tsx
@@ -70,50 +70,56 @@ const Filters = () => {
         emptyMessage={emptyMessage}
         itemClassName='pb-4 last:pb-0'
       >
-        {filters.map((filter) => (
-          <div key={filter.id} className='rounded-lg bg-gray-100 p-4 dark:bg-primary-800'>
-            <Stack space={2}>
-              <Stack className='grow' space={1}>
-                <Text weight='medium'>
-                  <FormattedMessage id='filters.filters_list_phrases_label' defaultMessage='Keywords or phrases:' />
-                  {' '}
-                  <Text theme='muted' tag='span'>{filter.keywords.map(keyword => keyword.keyword).join(', ')}</Text>
-                </Text>
-                <Text weight='medium'>
-                  <FormattedMessage id='filters.filters_list_context_label' defaultMessage='Filter contexts:' />
-                  {' '}
-                  <Text theme='muted' tag='span'>{filter.context.map(context => contexts[context] ? intl.formatMessage(contexts[context]) : context).join(', ')}</Text>
-                </Text>
-                <HStack space={4} wrap>
+        {filters.map((filter) => {
+
+          const truthMessageFilter = filter.filter_action === 'hide' ?
+            <FormattedMessage id='filters.filters_list_hide_completely' defaultMessage='Hide content' /> :
+            <FormattedMessage id='filters.filters_list_warn' defaultMessage='Display warning' />;
+
+          const falseMessageFilter = (filter.filter_action === 'hide' ?
+            <FormattedMessage id='filters.filters_list_drop' defaultMessage='Drop' /> :
+            <FormattedMessage id='filters.filters_list_hide' defaultMessage='Hide' />);
+
+          return (
+            <div key={filter.id} className='rounded-lg bg-gray-100 p-4 dark:bg-primary-800'>
+              <Stack space={2}>
+                <Stack className='grow' space={1}>
                   <Text weight='medium'>
-                    {filtersV2 ? (
-                      filter.filter_action === 'hide' ?
-                        <FormattedMessage id='filters.filters_list_hide_completely' defaultMessage='Hide content' /> :
-                        <FormattedMessage id='filters.filters_list_warn' defaultMessage='Display warning' />
-                    ) : (filter.filter_action === 'hide' ?
-                      <FormattedMessage id='filters.filters_list_drop' defaultMessage='Drop' /> :
-                      <FormattedMessage id='filters.filters_list_hide' defaultMessage='Hide' />)}
+                    <FormattedMessage id='filters.filters_list_phrases_label' defaultMessage='Keywords or phrases:' />
+                    {' '}
+                    <Text theme='muted' tag='span'>{filter.keywords.map(keyword => keyword.keyword).join(', ')}</Text>
                   </Text>
-                  {filter.expires_at && (
+                  <Text weight='medium'>
+                    <FormattedMessage id='filters.filters_list_context_label' defaultMessage='Filter contexts:' />
+                    {' '}
+                    <Text theme='muted' tag='span'>{filter.context.map(context => contexts[context] ? intl.formatMessage(contexts[context]) : context).join(', ')}</Text>
+                  </Text>
+                  <HStack space={4} wrap>
                     <Text weight='medium'>
-                      {new Date(filter.expires_at).getTime() <= Date.now()
-                        ? <FormattedMessage id='filters.filters_list_expired' defaultMessage='Expired' />
-                        : <RelativeTimestamp timestamp={filter.expires_at} className='whitespace-nowrap' futureDate />}
+                      {filtersV2 ? truthMessageFilter : falseMessageFilter}
                     </Text>
-                  )}
+                    {filter.expires_at && (
+                      <Text weight='medium'>
+                        {new Date(filter.expires_at).getTime() <= Date.now()
+                          ? <FormattedMessage id='filters.filters_list_expired' defaultMessage='Expired' />
+                          : <RelativeTimestamp timestamp={filter.expires_at} className='whitespace-nowrap' futureDate />}
+                      </Text>
+                    )}
+                  </HStack>
+                </Stack>
+                <HStack space={2} justifyContent='end'>
+                  <Button theme='primary' onClick={handleFilterEdit(filter.id)}>
+                    {intl.formatMessage(messages.edit)}
+                  </Button>
+                  <Button theme='danger' onClick={handleFilterDelete(filter.id)}>
+                    {intl.formatMessage(messages.delete)}
+                  </Button>
                 </HStack>
               </Stack>
-              <HStack space={2} justifyContent='end'>
-                <Button theme='primary' onClick={handleFilterEdit(filter.id)}>
-                  {intl.formatMessage(messages.edit)}
-                </Button>
-                <Button theme='danger' onClick={handleFilterDelete(filter.id)}>
-                  {intl.formatMessage(messages.delete)}
-                </Button>
-              </HStack>
-            </Stack>
-          </div>
-        ))}
+            </div>
+          );
+        },
+        )}
       </ScrollableList>
     </Column>
   );
diff --git a/src/features/ui/components/modals/captcha-modal/captcha-modal.tsx b/src/features/ui/components/modals/captcha-modal/captcha-modal.tsx
index 5dac02d2d..3818819b7 100644
--- a/src/features/ui/components/modals/captcha-modal/captcha-modal.tsx
+++ b/src/features/ui/components/modals/captcha-modal/captcha-modal.tsx
@@ -22,6 +22,8 @@ const CaptchaModal: React.FC<ICaptchaModal> = ({ onClose }) => {
     xPosition,
   } = useCaptcha();
 
+  const messageButton = tryAgain ? <FormattedMessage id='nostr_signup.captcha_try_again_button' defaultMessage='Try again' /> : <FormattedMessage id='nostr_signup.captcha_check_button' defaultMessage='Check' />;
+
   return (
     <Modal
       title={<FormattedMessage id='nostr_signup.captcha_title' defaultMessage='Human Verification' />} width='sm'
@@ -46,10 +48,7 @@ const CaptchaModal: React.FC<ICaptchaModal> = ({ onClose }) => {
             >
               {isSubmitting ? (
                 <FormattedMessage id='nostr_signup.captcha_check_button.checking' defaultMessage='Checking…' />
-              ) : (tryAgain ?
-                <FormattedMessage id='nostr_signup.captcha_try_again_button' defaultMessage='Try again' /> :
-                <FormattedMessage id='nostr_signup.captcha_check_button' defaultMessage='Check' />
-              )}
+              ) : messageButton}
             </Button>
             <Button onClick={loadCaptcha}>
               <FormattedMessage id='nostr_signup.captcha_reset_button' defaultMessage='Reset puzzle' />
diff --git a/src/normalizers/admin-account.ts b/src/normalizers/admin-account.ts
index 5f3b7d8cb..7422e123d 100644
--- a/src/normalizers/admin-account.ts
+++ b/src/normalizers/admin-account.ts
@@ -33,12 +33,18 @@ export const AdminAccountRecord = ImmutableRecord({
 
 const normalizePleromaAccount = (account: ImmutableMap<string, any>) => {
   if (!account.get('account')) {
+
+    const isAdmin = account.getIn(['roles', 'admin']);
+    const isModerator = account.getIn(['roles', 'moderator']) ? 'moderator' : null;
+
+    const accountRole = isAdmin ? 'admin' : isModerator;
+
     return account.withMutations(account => {
       account.set('approved', account.get('is_approved'));
       account.set('confirmed', account.get('is_confirmed'));
       account.set('disabled', !account.get('is_active'));
       account.set('invite_request', account.get('registration_reason'));
-      account.set('role', account.getIn(['roles', 'admin']) ? 'admin' : (account.getIn(['roles', 'moderator']) ? 'moderator' : null));
+      account.set('role', accountRole);
     });
   }