Remove FE_BUILD_DIR build config

docs/development/build-config.md

@@ -118,7 +118,7 @@ When compiling Soapbox, environment variables may be passed to change the build
 For example:
 
 ```sh
-NODE_ENV="production" FE_BUILD_DIR="public" FE_SUBDIRECTORY="/soapbox" yarn build
+NODE_ENV="production" FE_SUBDIRECTORY="/soapbox" yarn build
 ```
 
 ### `NODE_ENV`
@@ -147,16 +147,6 @@ Options:
 
 Default: `""`
 
-### `FE_BUILD_DIR`
-
-The folder to put build files in. This is mostly useful for CI tasks like GitLab Pages.
-
-Options:
-
-- Any directory name, eg `"public"`
-
-Default: `"dist"`
-
 ### `FE_SUBDIRECTORY`
 
 Subdirectory to host Soapbox out of.

src/build-config-compiletime.ts

@@ -12,7 +12,6 @@ const {
   NODE_ENV,
   BACKEND_URL,
   FE_SUBDIRECTORY,
-  FE_BUILD_DIR,
   FE_INSTANCE_SOURCE_DIR,
   SENTRY_DSN,
 } = process.env;
@@ -29,16 +28,11 @@ const sanitizeBasename = (path: string | undefined = ''): string => {
   return `/${trim(path, '/')}`;
 };
 
-const sanitizePath = (path: string | undefined = ''): string => {
-  return trim(path, '/');
-};
-
 export default () => ({
   data: {
     NODE_ENV: NODE_ENV || 'development',
     BACKEND_URL: sanitizeURL(BACKEND_URL),
     FE_SUBDIRECTORY: sanitizeBasename(FE_SUBDIRECTORY),
-    FE_BUILD_DIR: sanitizePath(FE_BUILD_DIR) || 'dist',
     FE_INSTANCE_SOURCE_DIR: FE_INSTANCE_SOURCE_DIR || 'instance',
     SENTRY_DSN,
   },

src/build-config.ts

@@ -3,7 +3,6 @@ const {
   NODE_ENV,
   BACKEND_URL,
   FE_SUBDIRECTORY,
-  FE_BUILD_DIR,
   FE_INSTANCE_SOURCE_DIR,
   SENTRY_DSN,
 } = import.meta.compileTime('./build-config-compiletime.ts');
@@ -12,7 +11,6 @@ export {
   NODE_ENV,
   BACKEND_URL,
   FE_SUBDIRECTORY,
-  FE_BUILD_DIR,
   FE_INSTANCE_SOURCE_DIR,
   SENTRY_DSN,
 };