Rearrange Like button events to prevent clashing

This commit is contained in:
Alex Gleason 2020-05-23 20:01:16 -05:00
parent e9596fc191
commit 29bcc4a0d1
No known key found for this signature in database
GPG Key ID: 7211D1F99744FBB7
3 changed files with 11 additions and 2 deletions

View File

@ -13,6 +13,8 @@ export default class IconButton extends React.PureComponent {
title: PropTypes.string.isRequired, title: PropTypes.string.isRequired,
icon: PropTypes.string.isRequired, icon: PropTypes.string.isRequired,
onClick: PropTypes.func, onClick: PropTypes.func,
onMouseEnter: PropTypes.func,
onMouseLeave: PropTypes.func,
size: PropTypes.number, size: PropTypes.number,
active: PropTypes.bool, active: PropTypes.bool,
pressed: PropTypes.bool, pressed: PropTypes.bool,
@ -36,6 +38,8 @@ export default class IconButton extends React.PureComponent {
overlay: false, overlay: false,
tabIndex: '0', tabIndex: '0',
onClick: () => {}, onClick: () => {},
onMouseEnter: () => {},
onMouseLeave: () => {},
}; };
handleClick = (e) => { handleClick = (e) => {
@ -90,6 +94,8 @@ export default class IconButton extends React.PureComponent {
title={title} title={title}
className={classes} className={classes}
onClick={this.handleClick} onClick={this.handleClick}
onMouseEnter={this.props.onMouseEnter}
onMouseLeave={this.props.onMouseLeave}
tabIndex={tabIndex} tabIndex={tabIndex}
disabled={disabled} disabled={disabled}
> >
@ -113,6 +119,8 @@ export default class IconButton extends React.PureComponent {
title={title} title={title}
className={classes} className={classes}
onClick={this.handleClick} onClick={this.handleClick}
onMouseEnter={this.props.onMouseEnter}
onMouseLeave={this.props.onMouseLeave}
tabIndex={tabIndex} tabIndex={tabIndex}
disabled={disabled} disabled={disabled}
> >

View File

@ -137,6 +137,7 @@ class StatusActionBar extends ImmutablePureComponent {
} else { } else {
this.props.onOpenUnauthorizedModal(); this.props.onOpenUnauthorizedModal();
} }
this.setState({ emojiSelectorVisible: false });
}; };
} }
@ -356,7 +357,6 @@ class StatusActionBar extends ImmutablePureComponent {
className='status__action-bar__counter status__action-bar__counter--favourite' className='status__action-bar__counter status__action-bar__counter--favourite'
onMouseEnter={this.handleLikeButtonHover} onMouseEnter={this.handleLikeButtonHover}
onMouseLeave={this.handleLikeButtonLeave} onMouseLeave={this.handleLikeButtonLeave}
onClick={this.handleLikeButtonClick}
ref={this.setRef} ref={this.setRef}
> >
<EmojiSelector onReact={this.handleReactClick} visible={emojiSelectorVisible} /> <EmojiSelector onReact={this.handleReactClick} visible={emojiSelectorVisible} />
@ -367,6 +367,7 @@ class StatusActionBar extends ImmutablePureComponent {
title={intl.formatMessage(messages.favourite)} title={intl.formatMessage(messages.favourite)}
icon='thumbs-up' icon='thumbs-up'
emoji={meEmojiReact} emoji={meEmojiReact}
onClick={this.handleLikeButtonClick}
/> />
{emojiReactCount !== 0 && <span className='detailed-status__link'>{emojiReactCount}</span>} {emojiReactCount !== 0 && <span className='detailed-status__link'>{emojiReactCount}</span>}
</div> </div>

View File

@ -309,7 +309,6 @@ class ActionBar extends React.PureComponent {
className='detailed-status__button detailed-status__button--favourite' className='detailed-status__button detailed-status__button--favourite'
onMouseEnter={this.handleLikeButtonHover} onMouseEnter={this.handleLikeButtonHover}
onMouseLeave={this.handleLikeButtonLeave} onMouseLeave={this.handleLikeButtonLeave}
onClick={this.handleLikeButtonClick}
ref={this.setRef} ref={this.setRef}
> >
<EmojiSelector onReact={this.handleReactClick} visible={emojiSelectorVisible} /> <EmojiSelector onReact={this.handleReactClick} visible={emojiSelectorVisible} />
@ -321,6 +320,7 @@ class ActionBar extends React.PureComponent {
icon='thumbs-up' icon='thumbs-up'
emoji={meEmojiReact} emoji={meEmojiReact}
text='Like' text='Like'
onClick={this.handleLikeButtonClick}
/> />
</div> </div>
{shareButton} {shareButton}