Lexical: Do not display two toolbars at once

Signed-off-by: marcin mikołajczak <git@mkljczk.pl>

app/soapbox/features/compose/editor/handlers/image.ts

@@ -0,0 +1,11 @@
+import { $createImageNode } from '../nodes/image-node';
+
+import type { LexicalNode } from 'lexical';
+import type { ImportHandler } from 'lexical-remark';
+
+const importImage: ImportHandler<any> /* TODO */ = (node: LexicalNode, parser) => {
+  const lexicalNode = $createImageNode({ altText: node.alt ?? '', src: node.url });
+  parser.append(lexicalNode);
+};
+
+export { importImage };

app/soapbox/features/compose/editor/nodes/image-component.tsx

@@ -148,15 +148,8 @@ const ImageComponent = ({
     (event: KeyboardEvent) => {
       const latestSelection = $getSelection();
       const buttonElem = buttonRef.current;
-      if (
+      if (isSelected && $isNodeSelection(latestSelection) && latestSelection.getNodes().length === 1) {
-        isSelected &&
+        if (buttonElem !== null && buttonElem !== document.activeElement) {
-        $isNodeSelection(latestSelection) &&
-        latestSelection.getNodes().length === 1
-      ) {
-        if (
-          buttonElem !== null &&
-          buttonElem !== document.activeElement
-        ) {
           event.preventDefault();
           buttonElem.focus();
           return true;

app/soapbox/features/compose/editor/plugins/autosuggest-plugin.tsx

@@ -120,18 +120,12 @@ const getScrollParent = (
   if (style.position === 'fixed') {
     return document.body;
   }
-  for (
+  for (let parent: HTMLElement | null = element; (parent = parent.parentElement);) {
-    let parent: HTMLElement | null = element;
-    (parent = parent.parentElement);
-
-  ) {
     style = getComputedStyle(parent);
     if (excludeStaticParent && style.position === 'static') {
       continue;
     }
-    if (
+    if (overflowRegex.test(style.overflow + style.overflowY + style.overflowX)) {
-      overflowRegex.test(style.overflow + style.overflowY + style.overflowX)
-    ) {
       return parent;
     }
   }
@@ -418,17 +412,16 @@ const AutosuggestPlugin = ({
       editor.getEditorState().read(() => {
         const range = document.createRange();
         const match = getQueryTextForSearch(editor);
+        const nativeSelection = window.getSelection();
 
-        if (!match) {
+        if (!match || nativeSelection?.anchorOffset !== nativeSelection?.focusOffset) {
           closeTypeahead();
           return;
         }
 
         dispatch(fetchComposeSuggestions(composeId, match.matchingString.trim()));
 
-        if (
+        if (!isSelectionOnEntityBoundary(editor, match.leadOffset)) {
-          !isSelectionOnEntityBoundary(editor, match.leadOffset)
-        ) {
           const isRangePositioned = tryToPositionRange(match.leadOffset, range);
           if (isRangePositioned !== null) {
             startTransition(() =>

app/soapbox/features/compose/editor/plugins/floating-text-format-toolbar-plugin.tsx

@@ -119,10 +119,7 @@ const BlockTypeDropdown = ({ editor, anchorElem, blockType, icon }: {
   const formatParagraph = () => {
     editor.update(() => {
       const selection = $getSelection();
-      if (
+      if ($isRangeSelection(selection) || DEPRECATED_$isGridSelection(selection)) {
-        $isRangeSelection(selection) ||
-        DEPRECATED_$isGridSelection(selection)
-      ) {
         $setBlocksType(selection, () => $createParagraphNode());
       }
     });
@@ -509,10 +506,7 @@ const useFloatingTextFormatToolbar = (
         setIsLink(false);
       }
 
-      if (
+      if (!$isCodeHighlightNode(selection.anchor.getNode()) && selection.getTextContent() !== '') {
-        !$isCodeHighlightNode(selection.anchor.getNode()) &&
-        selection.getTextContent() !== ''
-      ) {
         setIsText($isTextNode(node));
       } else {
         setIsText(false);

app/soapbox/features/compose/editor/plugins/focus-plugin.tsx

@@ -20,10 +20,7 @@ const FocusPlugin: React.FC<IFocusPlugin> = ({ autoFocus }) => {
       () => {
         const activeElement = document.activeElement;
         const rootElement = editor.getRootElement();
-        if (
+        if (rootElement !== null && (activeElement === null || !rootElement.contains(activeElement))) {
-          rootElement !== null &&
-          (activeElement === null || !rootElement.contains(activeElement))
-        ) {
           rootElement.focus({ preventScroll: true });
         }
       }, { defaultSelection: 'rootEnd' },