From 65f03707e4fc0cceab135e295a830a89881b4b76 Mon Sep 17 00:00:00 2001 From: "P. Reis" Date: Wed, 11 Dec 2024 16:34:56 -0300 Subject: [PATCH] refactor: type cast, remove question marks --- src/components/media-gallery.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/media-gallery.tsx b/src/components/media-gallery.tsx index 9b59bab2d..dfa824542 100644 --- a/src/components/media-gallery.tsx +++ b/src/components/media-gallery.tsx @@ -44,7 +44,7 @@ const withinLimits = (aspectRatio: number) => { }; const shouldLetterbox = (attachment: Attachment): boolean => { - const aspectRatio = 'meta' in attachment && 'original' in attachment.meta && (attachment)?.meta?.original?.aspect; + const aspectRatio = 'meta' in attachment && 'original' in attachment.meta && (attachment).meta.original?.aspect; if (!aspectRatio) return true; @@ -158,7 +158,7 @@ const Item: React.FC = ({ const attachmentIcon = ( ); @@ -322,7 +322,7 @@ const MediaGallery: React.FC = (props) => { const getSizeDataSingle = (): SizeData => { const w = width || defaultWidth; - const aspectRatio = 'meta' in media[0] && 'original' in media[0].meta && (media[0])?.meta?.original?.aspect; + const aspectRatio = 'meta' in media[0] && 'original' in media[0].meta && (media[0])?.meta.original?.aspect; const getHeight = () => { if (!aspectRatio) return w * 9 / 16; @@ -348,7 +348,7 @@ const MediaGallery: React.FC = (props) => { let itemsDimensions: Dimensions[] = []; const ratios = Array(size).fill(null).map((_, i) => - 'meta' in media[i] && 'original' in media[i].meta && typeof media[i].meta?.original?.aspect === 'number' + 'meta' in media[i] && 'original' in media[i].meta && typeof media[i].meta.original?.aspect === 'number' ? media[i].meta.original.aspect : undefined as unknown as number, // NOTE: the old logic returned undefined anyways, and the implementation of the functions below call 'isNaN', such as the 'isPortrait' function );