Break composer upload into a generic component

app/soapbox/components/media-gallery.tsx

@@ -4,7 +4,7 @@ import React, { useState, useRef, useEffect } from 'react';
 import Blurhash from 'soapbox/components/blurhash';
 import Icon from 'soapbox/components/icon';
 import StillImage from 'soapbox/components/still-image';
-import { MIMETYPE_ICONS } from 'soapbox/features/compose/components/upload';
+import { MIMETYPE_ICONS } from 'soapbox/components/upload';
 import { useSettings } from 'soapbox/hooks';
 import { Attachment } from 'soapbox/types/entities';
 import { truncateFilename } from 'soapbox/utils/media';

app/soapbox/components/upload.tsx

@@ -0,0 +1,213 @@
+import classNames from 'clsx';
+import { List as ImmutableList } from 'immutable';
+import React, { useState } from 'react';
+import { defineMessages, useIntl, FormattedMessage } from 'react-intl';
+import { spring } from 'react-motion';
+
+import { openModal } from 'soapbox/actions/modals';
+import Blurhash from 'soapbox/components/blurhash';
+import Icon from 'soapbox/components/icon';
+import IconButton from 'soapbox/components/icon-button';
+import Motion from 'soapbox/features/ui/util/optional-motion';
+import { useAppDispatch } from 'soapbox/hooks';
+import { Attachment } from 'soapbox/types/entities';
+
+const bookIcon = require('@tabler/icons/book.svg');
+const fileCodeIcon = require('@tabler/icons/file-code.svg');
+const fileSpreadsheetIcon = require('@tabler/icons/file-spreadsheet.svg');
+const fileTextIcon = require('@tabler/icons/file-text.svg');
+const fileZipIcon = require('@tabler/icons/file-zip.svg');
+const defaultIcon = require('@tabler/icons/paperclip.svg');
+const presentationIcon = require('@tabler/icons/presentation.svg');
+
+export const MIMETYPE_ICONS: Record<string, string> = {
+  'application/x-freearc': fileZipIcon,
+  'application/x-bzip': fileZipIcon,
+  'application/x-bzip2': fileZipIcon,
+  'application/gzip': fileZipIcon,
+  'application/vnd.rar': fileZipIcon,
+  'application/x-tar': fileZipIcon,
+  'application/zip': fileZipIcon,
+  'application/x-7z-compressed': fileZipIcon,
+  'application/x-csh': fileCodeIcon,
+  'application/html': fileCodeIcon,
+  'text/javascript': fileCodeIcon,
+  'application/json': fileCodeIcon,
+  'application/ld+json': fileCodeIcon,
+  'application/x-httpd-php': fileCodeIcon,
+  'application/x-sh': fileCodeIcon,
+  'application/xhtml+xml': fileCodeIcon,
+  'application/xml': fileCodeIcon,
+  'application/epub+zip': bookIcon,
+  'application/vnd.oasis.opendocument.spreadsheet': fileSpreadsheetIcon,
+  'application/vnd.ms-excel': fileSpreadsheetIcon,
+  'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet': fileSpreadsheetIcon,
+  'application/pdf': fileTextIcon,
+  'application/vnd.oasis.opendocument.presentation': presentationIcon,
+  'application/vnd.ms-powerpoint': presentationIcon,
+  'application/vnd.openxmlformats-officedocument.presentationml.presentation': presentationIcon,
+  'text/plain': fileTextIcon,
+  'application/rtf': fileTextIcon,
+  'application/msword': fileTextIcon,
+  'application/x-abiword': fileTextIcon,
+  'application/vnd.openxmlformats-officedocument.wordprocessingml.document': fileTextIcon,
+  'application/vnd.oasis.opendocument.text': fileTextIcon,
+};
+
+const messages = defineMessages({
+  description: { id: 'upload_form.description', defaultMessage: 'Describe for the visually impaired' },
+  delete: { id: 'upload_form.undo', defaultMessage: 'Delete' },
+});
+
+interface IUpload {
+  media: Attachment,
+  onSubmit?(): void,
+  onDelete?(): void,
+  onDescriptionChange?(description: string): void,
+  descriptionLimit?: number,
+  withPreview?: boolean,
+}
+
+const Upload: React.FC<IUpload> = ({
+  media,
+  onSubmit,
+  onDelete,
+  onDescriptionChange,
+  descriptionLimit,
+  withPreview = true,
+}) => {
+  const intl = useIntl();
+  const dispatch = useAppDispatch();
+
+  const [hovered, setHovered] = useState(false);
+  const [focused, setFocused] = useState(false);
+  const [dirtyDescription, setDirtyDescription] = useState<string | null>(null);
+
+  const handleKeyDown: React.KeyboardEventHandler = (e) => {
+    if (onSubmit && e.keyCode === 13 && (e.ctrlKey || e.metaKey)) {
+      handleInputBlur();
+      onSubmit();
+    }
+  };
+
+  const handleUndoClick: React.MouseEventHandler = e => {
+    if (onDelete) {
+      e.stopPropagation();
+      onDelete();
+    }
+  };
+
+  const handleInputChange: React.ChangeEventHandler<HTMLTextAreaElement> = e => {
+    setDirtyDescription(e.target.value);
+  };
+
+  const handleMouseEnter = () => {
+    setHovered(true);
+  };
+
+  const handleMouseLeave = () => {
+    setHovered(false);
+  };
+
+  const handleInputFocus = () => {
+    setFocused(true);
+  };
+
+  const handleClick = () => {
+    setFocused(true);
+  };
+
+  const handleInputBlur = () => {
+    setFocused(false);
+    setDirtyDescription(null);
+
+    if (dirtyDescription !== null && onDescriptionChange) {
+      onDescriptionChange(dirtyDescription);
+    }
+  };
+
+  const handleOpenModal = () => {
+    dispatch(openModal('MEDIA', { media: ImmutableList.of(media), index: 0 }));
+  };
+
+  const active = hovered || focused;
+  const description = dirtyDescription || (dirtyDescription !== '' && media.description) || '';
+  const focusX = media.meta.getIn(['focus', 'x']) as number | undefined;
+  const focusY = media.meta.getIn(['focus', 'y']) as number | undefined;
+  const x = focusX ? ((focusX /  2) + .5) * 100 : undefined;
+  const y = focusY ? ((focusY / -2) + .5) * 100 : undefined;
+  const mediaType = media.type;
+  const mimeType = media.pleroma.get('mime_type') as string | undefined;
+
+  const uploadIcon = mediaType === 'unknown' && (
+    <Icon
+      className='h-16 w-16 mx-auto my-12 text-gray-800 dark:text-gray-200'
+      src={MIMETYPE_ICONS[mimeType || ''] || defaultIcon}
+    />
+  );
+
+  return (
+    <div className='compose-form__upload' tabIndex={0} onMouseEnter={handleMouseEnter} onMouseLeave={handleMouseLeave} onClick={handleClick} role='button'>
+      <Blurhash hash={media.blurhash} className='media-gallery__preview' />
+      <Motion defaultStyle={{ scale: 0.8 }} style={{ scale: spring(1, { stiffness: 180, damping: 12 }) }}>
+        {({ scale }) => (
+          <div
+            className={classNames('compose-form__upload-thumbnail',  mediaType)}
+            style={{
+              transform: `scale(${scale})`,
+              backgroundImage: mediaType === 'image' ? `url(${media.preview_url})` : undefined,
+              backgroundPosition: typeof x === 'number' && typeof y === 'number' ? `${x}% ${y}%` : undefined }}
+          >
+            <div className={classNames('compose-form__upload__actions', { active })}>
+              {onDelete && (
+                <IconButton
+                  onClick={handleUndoClick}
+                  src={require('@tabler/icons/x.svg')}
+                  text={<FormattedMessage id='upload_form.undo' defaultMessage='Delete' />}
+                />
+              )}
+
+              {/* Only display the "Preview" button for a valid attachment with a URL */}
+              {(withPreview && mediaType !== 'unknown' && Boolean(media.url)) && (
+                <IconButton
+                  onClick={handleOpenModal}
+                  src={require('@tabler/icons/zoom-in.svg')}
+                  text={<FormattedMessage id='upload_form.preview' defaultMessage='Preview' />}
+                />
+              )}
+            </div>
+
+            {onDescriptionChange && (
+              <div className={classNames('compose-form__upload-description', { active })}>
+                <label>
+                  <span style={{ display: 'none' }}>{intl.formatMessage(messages.description)}</span>
+
+                  <textarea
+                    placeholder={intl.formatMessage(messages.description)}
+                    value={description}
+                    maxLength={descriptionLimit}
+                    onFocus={handleInputFocus}
+                    onChange={handleInputChange}
+                    onBlur={handleInputBlur}
+                    onKeyDown={handleKeyDown}
+                  />
+                </label>
+              </div>
+            )}
+
+            <div className='compose-form__upload-preview'>
+              {mediaType === 'video' && (
+                <video autoPlay playsInline muted loop>
+                  <source src={media.preview_url} />
+                </video>
+              )}
+              {uploadIcon}
+            </div>
+          </div>
+        )}
+      </Motion>
+    </div>
+  );
+};
+
+export default Upload;

app/soapbox/features/compose/components/upload.tsx

@@ -1,206 +1,44 @@
-import classNames from 'clsx';
+import React from 'react';
-import { List as ImmutableList } from 'immutable';
-import React, { useState } from 'react';
-import { defineMessages, useIntl, FormattedMessage } from 'react-intl';
-import { spring } from 'react-motion';
 import { useHistory } from 'react-router-dom';
 
 import { undoUploadCompose, changeUploadCompose, submitCompose } from 'soapbox/actions/compose';
-import { openModal } from 'soapbox/actions/modals';
+import Upload from 'soapbox/components/upload';
-import Blurhash from 'soapbox/components/blurhash';
-import Icon from 'soapbox/components/icon';
-import IconButton from 'soapbox/components/icon-button';
 import { useAppDispatch, useCompose, useInstance } from 'soapbox/hooks';
 
-import Motion from '../../ui/util/optional-motion';
+interface IUploadCompose {
-
-const bookIcon = require('@tabler/icons/book.svg');
-const fileCodeIcon = require('@tabler/icons/file-code.svg');
-const fileSpreadsheetIcon = require('@tabler/icons/file-spreadsheet.svg');
-const fileTextIcon = require('@tabler/icons/file-text.svg');
-const fileZipIcon = require('@tabler/icons/file-zip.svg');
-const defaultIcon = require('@tabler/icons/paperclip.svg');
-const presentationIcon = require('@tabler/icons/presentation.svg');
-
-export const MIMETYPE_ICONS: Record<string, string> = {
-  'application/x-freearc': fileZipIcon,
-  'application/x-bzip': fileZipIcon,
-  'application/x-bzip2': fileZipIcon,
-  'application/gzip': fileZipIcon,
-  'application/vnd.rar': fileZipIcon,
-  'application/x-tar': fileZipIcon,
-  'application/zip': fileZipIcon,
-  'application/x-7z-compressed': fileZipIcon,
-  'application/x-csh': fileCodeIcon,
-  'application/html': fileCodeIcon,
-  'text/javascript': fileCodeIcon,
-  'application/json': fileCodeIcon,
-  'application/ld+json': fileCodeIcon,
-  'application/x-httpd-php': fileCodeIcon,
-  'application/x-sh': fileCodeIcon,
-  'application/xhtml+xml': fileCodeIcon,
-  'application/xml': fileCodeIcon,
-  'application/epub+zip': bookIcon,
-  'application/vnd.oasis.opendocument.spreadsheet': fileSpreadsheetIcon,
-  'application/vnd.ms-excel': fileSpreadsheetIcon,
-  'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet': fileSpreadsheetIcon,
-  'application/pdf': fileTextIcon,
-  'application/vnd.oasis.opendocument.presentation': presentationIcon,
-  'application/vnd.ms-powerpoint': presentationIcon,
-  'application/vnd.openxmlformats-officedocument.presentationml.presentation': presentationIcon,
-  'text/plain': fileTextIcon,
-  'application/rtf': fileTextIcon,
-  'application/msword': fileTextIcon,
-  'application/x-abiword': fileTextIcon,
-  'application/vnd.openxmlformats-officedocument.wordprocessingml.document': fileTextIcon,
-  'application/vnd.oasis.opendocument.text': fileTextIcon,
-};
-
-const messages = defineMessages({
-  description: { id: 'upload_form.description', defaultMessage: 'Describe for the visually impaired' },
-  delete: { id: 'upload_form.undo', defaultMessage: 'Delete' },
-});
-
-interface IUpload {
   id: string,
   composeId: string,
 }
 
-const Upload: React.FC<IUpload> = ({ composeId, id }) => {
+const UploadCompose: React.FC<IUploadCompose> = ({ composeId, id }) => {
-  const intl = useIntl();
   const history = useHistory();
   const dispatch = useAppDispatch();
   const { description_limit: descriptionLimit } = useInstance();
 
   const media = useCompose(composeId).media_attachments.find(item => item.id === id)!;
 
-  const [hovered, setHovered] = useState(false);
-  const [focused, setFocused] = useState(false);
-  const [dirtyDescription, setDirtyDescription] = useState<string | null>(null);
-
-  const handleKeyDown: React.KeyboardEventHandler = (e) => {
-    if (e.keyCode === 13 && (e.ctrlKey || e.metaKey)) {
-      handleSubmit();
-    }
-  };
-
   const handleSubmit = () => {
-    handleInputBlur();
     dispatch(submitCompose(composeId, history));
   };
 
-  const handleUndoClick: React.MouseEventHandler = e => {
+  const handleDescriptionChange = (description: string) => {
-    e.stopPropagation();
+    dispatch(changeUploadCompose(composeId, media.id, { description }));
+  };
+
+  const handleDelete = () => {
     dispatch(undoUploadCompose(composeId, media.id));
   };
 
-  const handleInputChange: React.ChangeEventHandler<HTMLTextAreaElement> = e => {
-    setDirtyDescription(e.target.value);
-  };
-
-  const handleMouseEnter = () => {
-    setHovered(true);
-  };
-
-  const handleMouseLeave = () => {
-    setHovered(false);
-  };
-
-  const handleInputFocus = () => {
-    setFocused(true);
-  };
-
-  const handleClick = () => {
-    setFocused(true);
-  };
-
-  const handleInputBlur = () => {
-    setFocused(false);
-    setDirtyDescription(null);
-
-    if (dirtyDescription !== null) {
-      dispatch(changeUploadCompose(composeId, media.id, { description: dirtyDescription }));
-    }
-  };
-
-  const handleOpenModal = () => {
-    dispatch(openModal('MEDIA', { media: ImmutableList.of(media), index: 0 }));
-  };
-
-  const active = hovered || focused;
-  const description = dirtyDescription || (dirtyDescription !== '' && media.description) || '';
-  const focusX = media.meta.getIn(['focus', 'x']) as number | undefined;
-  const focusY = media.meta.getIn(['focus', 'y']) as number | undefined;
-  const x = focusX ? ((focusX /  2) + .5) * 100 : undefined;
-  const y = focusY ? ((focusY / -2) + .5) * 100 : undefined;
-  const mediaType = media.type;
-  const mimeType = media.pleroma.get('mime_type') as string | undefined;
-
-  const uploadIcon = mediaType === 'unknown' && (
-    <Icon
-      className='h-16 w-16 mx-auto my-12 text-gray-800 dark:text-gray-200'
-      src={MIMETYPE_ICONS[mimeType || ''] || defaultIcon}
-    />
-  );
-
   return (
-    <div className='compose-form__upload' tabIndex={0} onMouseEnter={handleMouseEnter} onMouseLeave={handleMouseLeave} onClick={handleClick} role='button'>
+    <Upload
-      <Blurhash hash={media.blurhash} className='media-gallery__preview' />
+      media={media}
-      <Motion defaultStyle={{ scale: 0.8 }} style={{ scale: spring(1, { stiffness: 180, damping: 12 }) }}>
+      onDelete={handleDelete}
-        {({ scale }) => (
+      onDescriptionChange={handleDescriptionChange}
-          <div
+      onSubmit={handleSubmit}
-            className={classNames('compose-form__upload-thumbnail',  mediaType)}
+      descriptionLimit={descriptionLimit}
-            style={{
+      withPreview
-              transform: `scale(${scale})`,
+    />
-              backgroundImage: mediaType === 'image' ? `url(${media.preview_url})` : undefined,
-              backgroundPosition: typeof x === 'number' && typeof y === 'number' ? `${x}% ${y}%` : undefined }}
-          >
-            <div className={classNames('compose-form__upload__actions', { active })}>
-              <IconButton
-                onClick={handleUndoClick}
-                src={require('@tabler/icons/x.svg')}
-                text={<FormattedMessage id='upload_form.undo' defaultMessage='Delete' />}
-              />
-
-              {/* Only display the "Preview" button for a valid attachment with a URL */}
-              {(mediaType !== 'unknown' && Boolean(media.url)) && (
-                <IconButton
-                  onClick={handleOpenModal}
-                  src={require('@tabler/icons/zoom-in.svg')}
-                  text={<FormattedMessage id='upload_form.preview' defaultMessage='Preview' />}
-                />
-              )}
-            </div>
-
-            <div className={classNames('compose-form__upload-description', { active })}>
-              <label>
-                <span style={{ display: 'none' }}>{intl.formatMessage(messages.description)}</span>
-
-                <textarea
-                  placeholder={intl.formatMessage(messages.description)}
-                  value={description}
-                  maxLength={descriptionLimit}
-                  onFocus={handleInputFocus}
-                  onChange={handleInputChange}
-                  onBlur={handleInputBlur}
-                  onKeyDown={handleKeyDown}
-                />
-              </label>
-            </div>
-
-            <div className='compose-form__upload-preview'>
-              {mediaType === 'video' && (
-                <video autoPlay playsInline muted loop>
-                  <source src={media.preview_url} />
-                </video>
-              )}
-              {uploadIcon}
-            </div>
-          </div>
-        )}
-      </Motion>
-    </div>
   );
 };
 
-export default Upload;
+export default UploadCompose;