From 35522fef0958c2843107a6c9cce546e7e0dfcd44 Mon Sep 17 00:00:00 2001
From: vaartis <vaartis@cock.li>
Date: Mon, 17 Dec 2018 17:19:28 +0300
Subject: [PATCH] Use :ets.match_delete to delete old captchas

---
 lib/pleroma/captcha/kocaptcha.ex | 27 +++++++++++++++++++--------
 1 file changed, 19 insertions(+), 8 deletions(-)

diff --git a/lib/pleroma/captcha/kocaptcha.ex b/lib/pleroma/captcha/kocaptcha.ex
index 7f9637ad0..51900d123 100644
--- a/lib/pleroma/captcha/kocaptcha.ex
+++ b/lib/pleroma/captcha/kocaptcha.ex
@@ -19,7 +19,11 @@ def new() do
 
         token = json_resp["token"]
 
-        true = :ets.insert(@ets, {token, json_resp["md5"], DateTime.now_utc()})
+        true =
+          :ets.insert(
+            @ets,
+            {token, json_resp["md5"], DateTime.now_utc() |> DateTime.Format.unix()}
+          )
 
         %{type: :kocaptcha, token: token, url: endpoint <> json_resp["url"]}
     end
@@ -42,14 +46,21 @@ def validate(token, captcha) do
   @impl Service
   def cleanup() do
     seconds_retained = Pleroma.Config.get!([Pleroma.Captcha, :seconds_retained])
+    # If the time in ETS is less than current_time - seconds_retained, then the time has
+    # already passed
+    delete_after =
+      DateTime.subtract!(DateTime.now_utc(), seconds_retained) |> DateTime.Format.unix()
 
-    # Go through captchas and remove expired ones
-    :ets.tab2list(@ets)
-    |> Enum.each(fn {token, _, time_inserted} ->
-      # time created + expiration time = time when the captcha should be removed
-      remove_time = DateTime.add!(time_inserted, seconds_retained)
-      if DateTime.after?(DateTime.now_utc(), remove_time), do: :ets.delete(@ets, token)
-    end)
+    :ets.select_delete(
+      @ets,
+      [
+        {
+          {:_, :_, :"$1"},
+          [{:<, :"$1", {:const, delete_after}}],
+          [true]
+        }
+      ]
+    )
 
     :ok
   end