moon
/
spc-pleroma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'restore/card-img-alt' into 'develop' 

Include image description in status media cards

See merge request pleroma/pleroma!4108
This commit is contained in:
feld 2024-05-08 17:55:32 +00:00
parent 8eea4f58c7 ccceb41bf3
commit 6cfb0d7ddb
4 changed files with 27 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/card-image-description.add Normal file
View File

@ -0,0 +1 @@
Include image description in status media cards

4
lib/pleroma/web/api_spec/schemas/status.ex
View File

@ -58,6 +58,10 @@ defmodule Pleroma.Web.ApiSpec.Schemas.Status do
format: :uri,
description: "Preview thumbnail"
},
image_description: %Schema{
type: :string,
description: "Alternate text that describes what is in the thumbnail"
},
title: %Schema{type: :string, description: "Title of linked resource"},
description: %Schema{type: :string, description: "Description of preview"}
}

1
lib/pleroma/web/mastodon_api/views/status_view.ex
View File

@ -583,6 +583,7 @@ def render("card.json", %Card{fields: rich_media}) do
provider_url: page_url_data.scheme <> "://" <> page_url_data.host,
url: page_url,
image: image_url,
image_description: rich_media["image:alt"] || "",
title: rich_media["title"] || "",
description: rich_media["description"] || "",
pleroma: %{

25
test/pleroma/web/mastodon_api/views/status_view_test.exs
View File

@ -738,7 +738,7 @@ test "a rich media card without a site name renders correctly" do
{:ok, card} =
Card.create(page_url, %{image: page_url <> "/example.jpg", title: "Example website"})
%{provider_name: "example.com"} = StatusView.render("card.json", card)
assert match?(%{provider_name: "example.com"}, StatusView.render("card.json", card))
end
test "a rich media card without a site name or image renders correctly" do
@ -751,7 +751,7 @@ test "a rich media card without a site name or image renders correctly" do
{:ok, card} = Card.create(page_url, fields)
%{provider_name: "example.com"} = StatusView.render("card.json", card)
assert match?(%{provider_name: "example.com"}, StatusView.render("card.json", card))
end
test "a rich media card without an image renders correctly" do
@ -765,7 +765,24 @@ test "a rich media card without an image renders correctly" do
{:ok, card} = Card.create(page_url, fields)
%{provider_name: "example.com"} = StatusView.render("card.json", card)
assert match?(%{provider_name: "example.com"}, StatusView.render("card.json", card))
end
test "a rich media card without descriptions returns the fields with empty strings" do
page_url = "https://example.com"
fields = %{
"url" => page_url,
"site_name" => "Example site name",
"title" => "Example website"
}
{:ok, card} = Card.create(page_url, fields)
assert match?(
%{description: "", image_description: ""},
StatusView.render("card.json", card)
)
end
test "a rich media card with all relevant data renders correctly" do
@ -781,7 +798,7 @@ test "a rich media card with all relevant data renders correctly" do
{:ok, card} = Card.create(page_url, fields)
%{provider_name: "example.com"} = StatusView.render("card.json", card)
assert match?(%{provider_name: "example.com"}, StatusView.render("card.json", card))
end
test "a rich media card has all media proxied" do