tests: simplify object fetching and containment tests

test/object/containment_test.exs

@@ -65,7 +65,7 @@ test "users cannot be collided through fake direction spoofing attempts" do
       assert capture_log(fn ->
                {:error, _} = User.get_or_fetch_by_ap_id("https://n1u.moe/users/rye")
              end) =~
-               "[error] Could not decode user at fetch https://n1u.moe/users/rye, {:error, :error}"
+               "[error] Could not decode user at fetch https://n1u.moe/users/rye"
     end
   end
 

test/object/fetcher_test.exs

@@ -27,31 +27,16 @@ defmodule Pleroma.Object.FetcherTest do
   end
 
   describe "actor origin containment" do
-    test_with_mock "it rejects objects with a bogus origin",
+    test "it rejects objects with a bogus origin" do
-                   Pleroma.Web.OStatus,
-                   [:passthrough],
-                   [] do
       {:error, _} = Fetcher.fetch_object_from_id("https://info.pleroma.site/activity.json")
-
-      refute called(Pleroma.Web.OStatus.fetch_activity_from_url(:_))
     end
 
-    test_with_mock "it rejects objects when attributedTo is wrong (variant 1)",
+    test "it rejects objects when attributedTo is wrong (variant 1)" do
-                   Pleroma.Web.OStatus,
-                   [:passthrough],
-                   [] do
       {:error, _} = Fetcher.fetch_object_from_id("https://info.pleroma.site/activity2.json")
-
-      refute called(Pleroma.Web.OStatus.fetch_activity_from_url(:_))
     end
 
-    test_with_mock "it rejects objects when attributedTo is wrong (variant 2)",
+    test "it rejects objects when attributedTo is wrong (variant 2)" do
-                   Pleroma.Web.OStatus,
-                   [:passthrough],
-                   [] do
       {:error, _} = Fetcher.fetch_object_from_id("https://info.pleroma.site/activity3.json")
-
-      refute called(Pleroma.Web.OStatus.fetch_activity_from_url(:_))
     end
   end