Treat warnings as errors outside of tests.

lib/pleroma/web/federator/federator.ex

@@ -150,7 +150,7 @@ def handle(type, _) do
   end
 
   if Mix.env() == :test do
-    def enqueue(type, payload, priority \\ 1) do
+    def enqueue(type, payload, _priority \\ 1) do
       if Pleroma.Config.get([:instance, :federating]) do
         handle(type, payload)
       end

mix.exs

@@ -8,6 +8,11 @@ def project do
       elixir: "~> 1.4",
       elixirc_paths: elixirc_paths(Mix.env()),
       compilers: [:phoenix, :gettext] ++ Mix.compilers(),
+      elixirc_options: if Mix.env() == :test do
+        []
+      else
+        [warnings_as_errors: true]
+      end,
       start_permanent: Mix.env() == :prod,
       aliases: aliases(),
       deps: deps(),

test/support/builders/activity_builder.ex

@@ -1,5 +1,4 @@
 defmodule Pleroma.Builders.ActivityBuilder do
-  alias Pleroma.Builders.UserBuilder
   alias Pleroma.Web.ActivityPub.ActivityPub
 
   def build(data \\ %{}, opts \\ %{}) do

test/support/http_request_mock.ex

@@ -13,7 +13,7 @@ def request(
     with {:ok, res} <- apply(__MODULE__, method, [url, query, body, headers]) do
       res
     else
-      {_, r} = error ->
+      {_, _r} = error ->
         # Logger.warn(r)
         error
     end

test/support/websub_mock.ex

@@ -0,0 +1,5 @@
+defmodule Pleroma.Web.WebsubMock do
+  def verify(sub) do
+    {:ok, sub}
+  end
+end

test/web/websub/websub_test.exs

@@ -1,9 +1,3 @@
-defmodule Pleroma.Web.WebsubMock do
-  def verify(sub) do
-    {:ok, sub}
-  end
-end
-
 defmodule Pleroma.Web.WebsubTest do
   use Pleroma.DataCase
   alias Pleroma.Web.Websub