Merge branch '1427-oauth-graceful-admin-scope' into 'develop'

[#1427] Graceful clearance of OAuth admin scopes for non-admin users

Closes #1427

See merge request pleroma/pleroma!2061

lib/pleroma/web/oauth/scopes.ex

@@ -79,7 +79,9 @@ defp authorize_admin_scopes(scopes, app_scopes, %User{} = user) do
     if user.is_admin || !contains_admin_scopes?(scopes) || !contains_admin_scopes?(app_scopes) do
       {:ok, scopes}
     else
-      {:error, :unsupported_scopes}
+      # Gracefully dropping admin scopes from requested scopes if user isn't an admin (not raising)
+      scopes = scopes -- OAuthScopesPlug.filter_descendants(scopes, ["admin"])
+      validate(scopes, app_scopes, user)
     end
   end
 

test/web/oauth/oauth_controller_test.exs

@@ -567,11 +567,18 @@ test "with existing authentication and OOB `redirect_uri`, redirects to app with
   end
 
   describe "POST /oauth/authorize" do
-    test "redirects with oauth authorization" do
-      user = insert(:user)
-      app = insert(:oauth_app, scopes: ["read", "write", "follow"])
+    test "redirects with oauth authorization, " <>
+           "keeping only non-admin scopes for non-admin user" do
+      app = insert(:oauth_app, scopes: ["read", "write", "admin"])
       redirect_uri = OAuthController.default_redirect_uri(app)
 
+      non_admin = insert(:user, is_admin: false)
+      admin = insert(:user, is_admin: true)
+
+      for {user, expected_scopes} <- %{
+            non_admin => ["read:subscope", "write"],
+            admin => ["read:subscope", "write", "admin"]
+          } do
         conn =
           build_conn()
           |> post("/oauth/authorize", %{
@@ -580,7 +587,7 @@ test "redirects with oauth authorization" do
               "password" => "test",
               "client_id" => app.client_id,
               "redirect_uri" => redirect_uri,
-            "scope" => "read:subscope write",
+              "scope" => "read:subscope write admin",
               "state" => "statepassed"
             }
           })
@@ -593,7 +600,8 @@ test "redirects with oauth authorization" do
         assert %{"state" => "statepassed", "code" => code} = query
         auth = Repo.get_by(Authorization, token: code)
         assert auth
-      assert auth.scopes == ["read:subscope", "write"]
+        assert auth.scopes == expected_scopes
+      end
     end
 
     test "returns 401 for wrong credentials", %{conn: conn} do
@@ -623,13 +631,15 @@ test "returns 401 for wrong credentials", %{conn: conn} do
       assert result =~ "Invalid Username/Password"
     end
 
-    test "returns 401 for missing scopes", %{conn: conn} do
-      user = insert(:user)
-      app = insert(:oauth_app)
+    test "returns 401 for missing scopes " <>
+           "(including all admin-only scopes for non-admin user)" do
+      user = insert(:user, is_admin: false)
+      app = insert(:oauth_app, scopes: ["read", "write", "admin"])
       redirect_uri = OAuthController.default_redirect_uri(app)
 
+      for scope_param <- ["", "admin:read admin:write"] do
         result =
-        conn
+          build_conn()
           |> post("/oauth/authorize", %{
             "authorization" => %{
               "name" => user.nickname,
@@ -637,7 +647,7 @@ test "returns 401 for missing scopes", %{conn: conn} do
               "client_id" => app.client_id,
               "redirect_uri" => redirect_uri,
               "state" => "statepassed",
-            "scope" => ""
+              "scope" => scope_param
             }
           })
           |> html_response(:unauthorized)
@@ -649,6 +659,7 @@ test "returns 401 for missing scopes", %{conn: conn} do
         # Error message
         assert result =~ "This action is outside the authorized scopes"
       end
+    end
 
     test "returns 401 for scopes beyond app scopes hierarchy", %{conn: conn} do
       user = insert(:user)