# Pleroma: A lightweight social networking server # Copyright © 2017-2022 Pleroma Authors # SPDX-License-Identifier: AGPL-3.0-only defmodule Pleroma.Web.MediaProxyTest do use ExUnit.Case use Pleroma.Tests.Helpers alias Pleroma.Config alias Pleroma.UnstubbedConfigMock, as: ConfigMock alias Pleroma.Web.Endpoint alias Pleroma.Web.MediaProxy import Mox setup do ConfigMock |> stub_with(Pleroma.Test.StaticConfig) :ok end defp decode_result(encoded) do {:ok, decoded} = MediaProxy.decode_url(encoded) decoded end describe "when enabled" do setup do: clear_config([:media_proxy, :enabled], true) test "ignores invalid url" do assert MediaProxy.url(nil) == nil assert MediaProxy.url("") == nil end test "ignores relative url" do assert MediaProxy.url("/local") == "/local" assert MediaProxy.url("/") == "/" end test "ignores local url" do local_url = Endpoint.url() <> "/hello" local_root = Endpoint.url() assert MediaProxy.url(local_url) == local_url assert MediaProxy.url(local_root) == local_root end test "encodes and decodes URL" do url = "https://pleroma.soykaf.com/static/logo.png" encoded = MediaProxy.url(url) assert String.starts_with?( encoded, Config.get([:media_proxy, :base_url], Pleroma.Web.Endpoint.url()) ) assert String.ends_with?(encoded, "/logo.png") assert decode_result(encoded) == url end test "encodes and decodes URL without a path" do url = "https://pleroma.soykaf.com" encoded = MediaProxy.url(url) assert decode_result(encoded) == url end test "encodes and decodes URL without an extension" do url = "https://pleroma.soykaf.com/path/" encoded = MediaProxy.url(url) assert String.ends_with?(encoded, "/path") assert decode_result(encoded) == url end test "encodes and decodes URL and ignores query params for the path" do url = "https://pleroma.soykaf.com/static/logo.png?93939393939&bunny=true" encoded = MediaProxy.url(url) assert String.ends_with?(encoded, "/logo.png") assert decode_result(encoded) == url end test "validates signature" do encoded = MediaProxy.url("https://pleroma.social") clear_config( [Endpoint, :secret_key_base], "00000000000000000000000000000000000000000000000" ) [_, "proxy", sig, base64 | _] = URI.parse(encoded).path |> String.split("/") assert MediaProxy.decode_url(sig, base64) == {:error, :invalid_signature} end def test_verify_request_path_and_url(request_path, url, expected_result) do assert MediaProxy.verify_request_path_and_url(request_path, url) == expected_result assert MediaProxy.verify_request_path_and_url( %Plug.Conn{ params: %{"filename" => Path.basename(request_path)}, request_path: request_path }, url ) == expected_result end test "if first arg of `verify_request_path_and_url/2` is a Plug.Conn without \"filename\" " <> "parameter, `verify_request_path_and_url/2` returns :ok " do assert MediaProxy.verify_request_path_and_url( %Plug.Conn{params: %{}, request_path: "/some/path"}, "https://instance.com/file.jpg" ) == :ok assert MediaProxy.verify_request_path_and_url( %Plug.Conn{params: %{}, request_path: "/path/to/file.jpg"}, "https://instance.com/file.jpg" ) == :ok end test "`verify_request_path_and_url/2` preserves the encoded or decoded path" do test_verify_request_path_and_url( "/Hello world.jpg", "http://pleroma.social/Hello world.jpg", :ok ) test_verify_request_path_and_url( "/Hello%20world.jpg", "http://pleroma.social/Hello%20world.jpg", :ok ) test_verify_request_path_and_url( "/my%2Flong%2Furl%2F2019%2F07%2FS.jpg", "http://pleroma.social/my%2Flong%2Furl%2F2019%2F07%2FS.jpg", :ok ) test_verify_request_path_and_url( # Note: `conn.request_path` returns encoded url "/ANALYSE-DAI-_-LE-STABLECOIN-100-D%C3%89CENTRALIS%C3%89-BQ.jpg", "https://mydomain.com/uploads/2019/07/ANALYSE-DAI-_-LE-STABLECOIN-100-DÉCENTRALISÉ-BQ.jpg", :ok ) test_verify_request_path_and_url( "/my%2Flong%2Furl%2F2019%2F07%2FS", "http://pleroma.social/my%2Flong%2Furl%2F2019%2F07%2FS.jpg", {:wrong_filename, "my%2Flong%2Furl%2F2019%2F07%2FS.jpg"} ) end test "uses the configured base_url" do base_url = "https://cache.pleroma.social" clear_config([:media_proxy, :base_url], base_url) url = "https://pleroma.soykaf.com/static/logo.png" encoded = MediaProxy.url(url) assert String.starts_with?(encoded, base_url) end # Some sites expect ASCII encoded characters in the URL to be preserved even if # unnecessary. # Issues: https://git.pleroma.social/pleroma/pleroma/issues/580 # https://git.pleroma.social/pleroma/pleroma/issues/1055 test "preserve ASCII encoding" do url = "https://pleroma.com/%20/%21/%22/%23/%24/%25/%26/%27/%28/%29/%2A/%2B/%2C/%2D/%2E/%2F/%30/%31/%32/%33/%34/%35/%36/%37/%38/%39/%3A/%3B/%3C/%3D/%3E/%3F/%40/%41/%42/%43/%44/%45/%46/%47/%48/%49/%4A/%4B/%4C/%4D/%4E/%4F/%50/%51/%52/%53/%54/%55/%56/%57/%58/%59/%5A/%5B/%5C/%5D/%5E/%5F/%60/%61/%62/%63/%64/%65/%66/%67/%68/%69/%6A/%6B/%6C/%6D/%6E/%6F/%70/%71/%72/%73/%74/%75/%76/%77/%78/%79/%7A/%7B/%7C/%7D/%7E/%7F/%80/%81/%82/%83/%84/%85/%86/%87/%88/%89/%8A/%8B/%8C/%8D/%8E/%8F/%90/%91/%92/%93/%94/%95/%96/%97/%98/%99/%9A/%9B/%9C/%9D/%9E/%9F/%C2%A0/%A1/%A2/%A3/%A4/%A5/%A6/%A7/%A8/%A9/%AA/%AB/%AC/%C2%AD/%AE/%AF/%B0/%B1/%B2/%B3/%B4/%B5/%B6/%B7/%B8/%B9/%BA/%BB/%BC/%BD/%BE/%BF/%C0/%C1/%C2/%C3/%C4/%C5/%C6/%C7/%C8/%C9/%CA/%CB/%CC/%CD/%CE/%CF/%D0/%D1/%D2/%D3/%D4/%D5/%D6/%D7/%D8/%D9/%DA/%DB/%DC/%DD/%DE/%DF/%E0/%E1/%E2/%E3/%E4/%E5/%E6/%E7/%E8/%E9/%EA/%EB/%EC/%ED/%EE/%EF/%F0/%F1/%F2/%F3/%F4/%F5/%F6/%F7/%F8/%F9/%FA/%FB/%FC/%FD/%FE/%FF" encoded = MediaProxy.url(url) assert decode_result(encoded) == url end # This includes unsafe/reserved characters which are not interpreted as part of the URL # and would otherwise have to be ASCII encoded. It is our role to ensure the proxied URL # is unmodified, so we are testing these characters anyway. test "preserve non-unicode characters per RFC3986" do url = "https://pleroma.com/ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz1234567890-._~:/?#[]@!$&'()*+,;=|^`{}" encoded = MediaProxy.url(url) assert decode_result(encoded) == url end test "preserve unicode characters" do url = "https://ko.wikipedia.org/wiki/위키백과:대문" encoded = MediaProxy.url(url) assert decode_result(encoded) == url end end describe "when disabled" do setup do: clear_config([:media_proxy, :enabled], false) test "does not encode remote urls" do assert MediaProxy.url("https://google.fr") == "https://google.fr" end end describe "whitelist" do setup do: clear_config([:media_proxy, :enabled], true) test "mediaproxy whitelist" do clear_config([:media_proxy, :whitelist], ["https://google.com", "https://feld.me"]) url = "https://feld.me/foo.png" unencoded = MediaProxy.url(url) assert unencoded == url end # TODO: delete after removing support bare domains for media proxy whitelist test "mediaproxy whitelist bare domains whitelist (deprecated)" do clear_config([:media_proxy, :whitelist], ["google.com", "feld.me"]) url = "https://feld.me/foo.png" unencoded = MediaProxy.url(url) assert unencoded == url end test "does not change whitelisted urls" do clear_config([:media_proxy, :whitelist], ["mycdn.akamai.com"]) clear_config([:media_proxy, :base_url], "https://cache.pleroma.social") media_url = "https://mycdn.akamai.com" url = "#{media_url}/static/logo.png" encoded = MediaProxy.url(url) assert String.starts_with?(encoded, media_url) end test "ensure Pleroma.Upload base_url is always whitelisted" do media_url = "https://media.pleroma.social" ConfigMock |> stub(:get, fn [Pleroma.Upload, :base_url] -> media_url path -> Pleroma.Test.StaticConfig.get(path) end) url = "#{media_url}/static/logo.png" encoded = MediaProxy.url(url) assert String.starts_with?(encoded, media_url) end end end