Fix passwords (hopefully)

lib/channel-new.js

@@ -446,6 +446,18 @@ Channel.prototype.getIPRank = function (ip, callback) {
 Channel.prototype.join = function (user, password) {
     var self = this;
 
+    user.whenLoggedIn(function () {
+        self.getRank(user.name, function (err, rank) {
+            if (err) {
+                user.rank = user.global_rank;
+            } else {
+                user.rank = Math.max(rank, user.global_rank);
+            }
+
+            user.socket.emit("rank", user.rank);
+        });
+    });
+
     var afterIPBanCheck = function () {
         if (self.dead) {
             return;
@@ -497,23 +509,19 @@ Channel.prototype.join = function (user, password) {
             }
         }
 
-        self.getRank(user.name, function (err, rank) {
-            if (err) {
-                user.rank = user.global_rank;
-            } else {
-                user.rank = Math.max(rank, user.global_rank);
-            }
-
-            user.socket.emit("rank", user.rank);
         self.sendUserJoin(self.users, user);
         self.sendUserlist([user]);
-        });
     };
 
     self.whenReady(function () {
         if (self.opts.password !== false && user.rank < 2) {
             if (password !== self.opts.password) {
-                user.socket.emit("needPassword", typeof password === "undefined");
+                user.socket.emit("needPassword", typeof password !== "undefined");
+                user.whenLoggedIn(function () {
+                    if (user.rank >= 2) {
+                        self.join(user);
+                    }
+                });
                 return;
             }
         }

lib/user.js

@@ -176,6 +176,10 @@ User.prototype.initChannelCallbacks = function () {
     });
 
     self.socket.on("joinChannel", typecheck("object", {}, function (data) {
+        if (self.inChannel()) {
+            return;
+        }
+
         if (typeof data.name !== "string") {
             return;
         }

www/assets/js/callbacks.js

@@ -138,7 +138,10 @@ Callbacks = {
         var parent = chatDialog(div);
         parent.attr("id", "needpw");
         var sendpw = function () {
-            socket.emit("channelPassword", pwbox.val());
+            socket.emit("joinChannel", {
+                name: CHANNEL.name,
+                pw: pwbox.val()
+            });
             parent.remove();
         };
         submit.click(sendpw);