From 2ee182eb48ee836058973890fb6baa400d6c16b6 Mon Sep 17 00:00:00 2001 From: calzoneman Date: Tue, 2 Apr 2013 11:16:26 -0500 Subject: [PATCH] Fix checkbox glitchiness (Issue#21) --- www/assets/js/functions.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/www/assets/js/functions.js b/www/assets/js/functions.js index e71b890b..ed4cb0c8 100644 --- a/www/assets/js/functions.js +++ b/www/assets/js/functions.js @@ -702,7 +702,12 @@ function updateChatFilters(entries) { remove.click(remcallback); var actcallback = (function(filter) { return function() { - filter[2] = active.prop("checked"); + // Apparently when you check a checkbox, its value is changed + // before this callback. When you uncheck it, its value is not + // changed before this callback + // [](/amgic) + var enabled = active.prop("checked"); + filter[2] = (filter[2] == enabled) ? !enabled : enabled; socket.emit("chatFilter", { cmd: "update", filter: filter