moon
/
sync
mirror of https://github.com/calzoneman/sync.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve workaround for YouTube's shitty internal race conditions

This commit is contained in:
Calvin Montgomery 2014-05-09 20:09:17 -05:00
parent 3fcb855c35
commit 6c4168c675
1 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
www/js/player.js
View File

@ -28,6 +28,7 @@ var YouTubePlayer = function (data) {
self.paused = false; self.paused = false;
self.videoId = data.id; self.videoId = data.id;
self.videoLength = data.seconds; self.videoLength = data.seconds;
self.theYouTubeDevsNeedToFixThisShit = false;
var wmode = USEROPTS.wmode_transparent ? "transparent" : "opaque"; var wmode = USEROPTS.wmode_transparent ? "transparent" : "opaque";
self.player = new YT.Player("ytapiplayer", { self.player = new YT.Player("ytapiplayer", {
height: VHEIGHT, height: VHEIGHT,
@ -47,6 +48,19 @@ var YouTubePlayer = function (data) {
$("#ytapiplayer").width(VWIDTH).height(VHEIGHT); $("#ytapiplayer").width(VWIDTH).height(VHEIGHT);
}, },
onStateChange: function (ev) { onStateChange: function (ev) {
/**
* Race conditions suck.
* Race conditions in other peoples' code that you can't fix
* but are forced to work around suck more.
*/
if (ev.data === YT.PlayerState.PLAYING &&
self.theYouTubeDevsNeedToFixThisShit) {
PLAYER.seek(0);
PLAYER.pause();
self.theYouTubeDevsNeedToFixThisShit = false;
}
if(PLAYER.paused && ev.data != YT.PlayerState.PAUSED || if(PLAYER.paused && ev.data != YT.PlayerState.PAUSED ||
!PLAYER.paused && ev.data == YT.PlayerState.PAUSED) { !PLAYER.paused && ev.data == YT.PlayerState.PAUSED) {
self.paused = (ev.data == YT.PlayerState.PAUSED); self.paused = (ev.data == YT.PlayerState.PAUSED);
@ -1219,20 +1233,23 @@ function handleMediaUpdate(data) {
} }
if (wait) { if (wait) {
var tm = 1;
/* Stupid hack -- In this thrilling episode of /* Stupid hack -- In this thrilling episode of
"the YouTube API developers should eat a boat", the "the YouTube API developers should eat a boat", the
HTML5 player apparently breaks if I play()-seek(0)-pause() HTML5 player apparently breaks if I play()-seek(0)-pause()
quickly (as a "start buffering but don't play yet" quickly (as a "start buffering but don't play yet"
mechanism) mechanism)
Addendum 2014-05-09
Made this slightly less hacky by waiting for a PLAYING event
to fire instead of just waiting 500ms and assuming that's
long enough
*/ */
if (PLAYER.type === "yt") { if (PLAYER.type === "yt") {
tm = 500; PLAYER.theYouTubeDevsNeedToFixThisShit = true;
} } else {
setTimeout(function () {
PLAYER.seek(0); PLAYER.seek(0);
PLAYER.pause(); PLAYER.pause();
}, tm); }
return; return;
} }