Add some safety checks to PMs

lib/channel.js

@@ -2878,6 +2878,20 @@ Channel.prototype.handlePm = function (user, data) {
         return;
     }
 
+    if (data.to === user.name) {
+        user.socket.emit("errorMsg", {
+            msg: "You can't PM yourself!"
+        });
+        return;
+    }
+
+    if (!util.isValidUserName(data.to)) {
+        user.socket.emit("errorMsg", {
+            msg: data.to + " isn't a valid username."
+        });
+        return;
+    }
+
     var msg = data.msg.substring(0, 240);
     var to = null;
     for (var i = 0; i < this.users.length; i++) {
@@ -2888,6 +2902,9 @@ Channel.prototype.handlePm = function (user, data) {
     }
 
     if (!to) {
+        user.socket.emit("errorMsg", {
+            msg: data.to + " is not on this channel."
+        });
         return;
     }
 

www/assets/js/util.js

@@ -200,13 +200,15 @@ function addUserDropdown(entry) {
     }
 
     /* pm button */
-    var pm = $("<button/>").addClass("btn btn-xs btn-default")
+    if (name !== CLIENT.name) {
-        .text("Private Message")
+        var pm = $("<button/>").addClass("btn btn-xs btn-default")
-        .appendTo(btngroup)
+            .text("Private Message")
-        .click(function () {
+            .appendTo(btngroup)
-            initPm(name).find(".panel-heading").click();
+            .click(function () {
-            menu.hide();
+                initPm(name).find(".panel-heading").click();
-        });
+                menu.hide();
+            });
+    }
 
     /* give/remove leader (moderator+ only) */
     if (hasPermission("leaderctl")) {