moon
/
sync
mirror of https://github.com/calzoneman/sync.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Hoist sortUserlist outside of userlist population inner loop

This commit is contained in:
Calvin Montgomery 2018-05-24 23:49:28 -07:00
parent bfe0d75278
commit fdab26b792
4 changed files with 29 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -2,7 +2,7 @@
"author": "Calvin Montgomery", "author": "Calvin Montgomery",
"name": "CyTube", "name": "CyTube",
"description": "Online media synchronizer and chat", "description": "Online media synchronizer and chat",
"version": "3.55.7", "version": "3.55.8",
"repository": { "repository": {
"url": "http://github.com/calzoneman/sync" "url": "http://github.com/calzoneman/sync"
}, },

25
www/js/callbacks.js
View File

@ -487,32 +487,13 @@ Callbacks = {
userlist: function(data) { userlist: function(data) {
$(".userlist_item").remove(); $(".userlist_item").remove();
for(var i = 0; i < data.length; i++) { for(var i = 0; i < data.length; i++) {
Callbacks.addUser(data[i]); CyTube._internal_do_not_use_or_you_will_be_banned.addUserToList(data[i]);
} }
sortUserlist();
}, },
addUser: function(data) { addUser: function(data) {
var user = findUserlistItem(data.name); CyTube._internal_do_not_use_or_you_will_be_banned.addUserToList(data);
// Remove previous instance of user, if there was one
if(user !== null)
user.remove();
var div = $("<div/>")
.addClass("userlist_item");
var icon = $("<span/>").appendTo(div);
var nametag = $("<span/>").text(data.name).appendTo(div);
div.data("name", data.name);
div.data("rank", data.rank);
div.data("leader", Boolean(data.leader));
div.data("profile", data.profile);
div.data("meta", data.meta);
if (data.meta.muted || data.meta.smuted) {
div.data("icon", "glyphicon-volume-off");
} else {
div.data("icon", false);
}
formatUserlistItem(div);
addUserDropdown(div, data);
div.appendTo($("#userlist"));
sortUserlist(); sortUserlist();
}, },

1
www/js/data.js
View File

@ -76,6 +76,7 @@ CyTube.ui = {
CyTube.featureFlag = { CyTube.featureFlag = {
efficientEmotes: true efficientEmotes: true
}; };
CyTube._internal_do_not_use_or_you_will_be_banned = {};
function getOpt(k) { function getOpt(k) {
var v = NO_STORAGE ? readCookie(k) : localStorage.getItem(k); var v = NO_STORAGE ? readCookie(k) : localStorage.getItem(k);

24
www/js/util.js
View File

@ -3363,3 +3363,27 @@ CyTube.ui.changeVideoWidth = function uiChangeVideoWidth(direction) {
handleVideoResize(); handleVideoResize();
}; };
CyTube._internal_do_not_use_or_you_will_be_banned.addUserToList = function (data) {
var user = findUserlistItem(data.name);
// Remove previous instance of user, if there was one
if(user !== null)
user.remove();
var div = $("<div/>")
.addClass("userlist_item");
var icon = $("<span/>").appendTo(div);
var nametag = $("<span/>").text(data.name).appendTo(div);
div.data("name", data.name);
div.data("rank", data.rank);
div.data("leader", Boolean(data.leader));
div.data("profile", data.profile);
div.data("meta", data.meta);
if (data.meta.muted || data.meta.smuted) {
div.data("icon", "glyphicon-volume-off");
} else {
div.data("icon", false);
}
formatUserlistItem(div);
addUserDropdown(div, data);
div.appendTo($("#userlist"));
};